-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add create release proposal action #55690
Open
RafaelGSS
wants to merge
7
commits into
nodejs:main
Choose a base branch
from
RafaelGSS:add-release-proposal
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
63eca8d
build: add create release proposal action
RafaelGSS b6664a2
fixup! build: add create release proposal action
RafaelGSS d2b8624
fixup! fixup! build: add create release proposal action
RafaelGSS 66bd129
Update .github/workflows/create-release-proposal.yml
RafaelGSS 29ccc97
fixup! fixup! fixup! build: add create release proposal action
RafaelGSS 23fe596
Apply suggestions from code review
RafaelGSS 452c3c2
Apply suggestions from code review
RafaelGSS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
# This action requires the following secrets to be set on the repository: | ||
# GH_USER_NAME: GitHub user whose Jenkins and GitHub token are defined below | ||
# GH_USER_TOKEN: GitHub user token, to be used by ncu and to push changes | ||
# JENKINS_TOKEN: Jenkins token, to be used to check CI status | ||
|
||
name: Create Release Proposal | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
release-line: | ||
required: true | ||
type: number | ||
default: 23 | ||
description: 'The release line (without dots or prefix). e.g: 22' | ||
release-date: | ||
required: true | ||
type: string | ||
default: YYYY-MM-DD | ||
description: The release date in YYYY-MM-DD format | ||
|
||
concurrency: ${{ github.workflow }} | ||
|
||
env: | ||
NODE_VERSION: lts/* | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
releasePrepare: | ||
env: | ||
STAGING_BRANCH: v${{ inputs.release-line }}.x-staging | ||
RELEASE_BRANCH: v${{ inputs.release-line }}.x | ||
RELEASE_DATE: ${{ inputs.release-date }} | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 | ||
with: | ||
branch: ${{ env.STAGING_BRANCH }} | ||
# Needs the whole git history for ncu to work | ||
# See https://github.com/nodejs/node-core-utils/pull/486 | ||
fetch-depth: 0 | ||
|
||
# Install dependencies | ||
- name: Install Node.js | ||
uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3 | ||
with: | ||
node-version: ${{ env.NODE_VERSION }} | ||
|
||
- name: Install @node-core/utils | ||
run: npm install -g @node-core/utils | ||
|
||
- name: Configure @node-core/utils | ||
run: | | ||
ncu-config set branch "${RELEASE_BRANCH}" | ||
ncu-config set upstream origin | ||
ncu-config set username "$USERNAME" | ||
ncu-config set token "$GH_TOKEN" | ||
ncu-config set jenkins_token "$JENKINS_TOKEN" | ||
ncu-config set repo "$(echo "$GITHUB_REPOSITORY" | cut -d/ -f2)" | ||
ncu-config set owner "${GITHUB_REPOSITORY_OWNER}" | ||
env: | ||
USERNAME: ${{ secrets.JENKINS_USER }} | ||
GH_TOKEN: ${{ secrets.GH_USER_TOKEN }} | ||
JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }} | ||
|
||
- name: Start git node release prepare | ||
run: | | ||
./tools/actions/create-release.sh "${RELEASE_DATE}" '${{ inputs.release-line }}' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
#!/bin/sh | ||
|
||
set -xe | ||
|
||
RELEASE_DATE=$1 | ||
RafaelGSS marked this conversation as resolved.
Show resolved
Hide resolved
|
||
RELEASE_LINE=$2 | ||
|
||
git node release --prepare --skipBranchDiff | ||
# We use it to not specify the branch name as it changes based on | ||
# the commit list (semver-minor/semver-patch) | ||
git config push.default current | ||
awk "/## ${RELEASE_DATE}/,/^<a id=/{ if (!/^<a id=/) print }" \ | ||
"doc/changelogs/CHANGELOG_V${RELEASE_LINE}.md" |\ | ||
gh pr create --body-file - | ||
# TODO: ammend with proposal PR |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following best practices, inputs shouldn't be directly in bash expressions. Instead, story the input as a variable and access it like above