[v18.x] esm: fix broken assertion in legacyMainResolve
#55708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
aduh95
changed the title
legacyMainResolvelegacyMainResolve
richardlau
approved these changes
Nov 3, 2024
RedYetiDev
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
force-pushed
the
fix-legacyMainResolve-assert
branch
from
c78ec0c
to
0fd6321
Compare
aduh95
force-pushed
the
fix-legacyMainResolve-assert
branch
from
0fd6321
to
2f519b4
Compare
aduh95
force-pushed
the
fix-legacyMainResolve-assert
branch
from
2f519b4
to
ba1afa8
Compare
aduh95
force-pushed
the
fix-legacyMainResolve-assert
branch
from
ba1afa8
to
f6b7c51
Compare
richardlau
approved these changes
Nov 7, 2024
marco-ippolito
approved these changes
Nov 7, 2024
aduh95
added a commit
that referenced
this pull request
Nov 7, 2024
PR-URL: #55708 Fixes: #55692 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
|
Landed in 3059262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
main, this was superseded by #48325, but in #49644 (comment) it was decided to not backport it to v18.x. Unfortunately we have a lack of coverage for this part of the code, and we don't have a repro for the issue, so this PR doesn't contain tests, it'd be good to have one though.Fixes: #55692