fs: fix bufferSize option for opendir recursive #55744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Ethan-Arrowood
force-pushed
the
fix/issue-48820
branch
from
89d3789
to
afc6294
Compare
Ethan-Arrowood
added
the
fs
github-actions
bot
removed
the
request-ci
Ethan-Arrowood
changed the title
Ethan-Arrowood
force-pushed
the
fix/issue-48820
branch
from
afc6294
to
09a9ce9
Compare
anonrig
approved these changes
Nov 7, 2024
Ethan-Arrowood
force-pushed
the
fix/issue-48820
branch
from
09a9ce9
to
3d1821d
Compare
targos
approved these changes
Nov 7, 2024
Ethan-Arrowood
added
commit-queue
|
Could you make sure to document the issues with this new code (not sure if it's best put in comments or as a ticket)? I assume it's something along the lines of |
|
I'll add a comment and open a new issue 👍 |
The bufferSize option was not respected in recursive mode. This PR implements a naive solution to fix this issue until a better implementation can be designed. Fixes: nodejs#48820
Ethan-Arrowood
force-pushed
the
fix/issue-48820
branch
from
3d1821d
to
75b300a
Compare
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55744 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 654 654
Lines 187747 187756 +9
Branches 36127 36128 +1
=======================================
+ Hits 165972 165985 +13
- Misses 15009 15010 +1
+ Partials 6766 6761 -5
|
Ethan-Arrowood
added
the
commit-queue
|
CI is passing except for some flaky tests as far as I can tell. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55744 ✔ Done loading data for nodejs/node/pull/55744 ----------------------------------- PR info ------------------------------------ Title fs: fix bufferSize option for opendir recursive (#55744) Author Ethan Arrowood <[email protected]> (@Ethan-Arrowood) Branch Ethan-Arrowood:fix/issue-48820 -> nodejs:main Labels fs, test, needs-ci Commits 1 - fs: fix bufferSize option for opendir recursive Committers 1 - Ethan Arrowood <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55744 Fixes: https://github.com/nodejs/node/issues/48820 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55744 Fixes: https://github.com/nodejs/node/issues/48820 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fs: fix bufferSize option for opendir recursive ℹ This PR was created on Wed, 06 Nov 2024 12:12:12 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/55744#pullrequestreview-2420753399 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/55744#pullrequestreview-2420811043 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-11-08T12:03:25Z: https://ci.nodejs.org/job/node-test-pull-request/63487/ - Querying data for job/node-test-pull-request/63487/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11742390923 |
anonrig
approved these changes
Nov 8, 2024
targos
approved these changes
Nov 8, 2024
Ethan-Arrowood
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e0ef622 |
|
Should we consider backporting this since it is a bug fix affecting all current versions? |
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
The bufferSize option was not respected in recursive mode. This PR implements a naive solution to fix this issue until a better implementation can be designed. Fixes: #48820 PR-URL: #55744 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bufferSize option was not respected in recursive mode. This PR
implements a naive solution to fix this issue until a better
implementation can be designed.
Fixes: #48820