Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix history info for URL.prototype.toJSON #55818

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 11, 2024

Fixes: #55806
Refs: #11236
Refs: #17365

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Nov 11, 2024
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 11, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2024
@nodejs-github-bot nodejs-github-bot merged commit be5a500 into nodejs:main Nov 13, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in be5a500

@aduh95 aduh95 deleted the toJSON-history branch November 13, 2024 17:10
aduh95 added a commit that referenced this pull request Nov 16, 2024
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing version info about some members of URL class & URLSearchParams class
5 participants