test: fix permission fixtures lint #55819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
aduh95
approved these changes
Nov 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55819 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 654 654
Lines 187811 187811
Branches 36134 36129 -5
==========================================
- Hits 166052 166044 -8
+ Misses 15008 15001 -7
- Partials 6751 6766 +15 |
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55819 ✔ Done loading data for nodejs/node/pull/55819 ----------------------------------- PR info ------------------------------------ Title test: fix permission fixtures lint (#55819) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:fix-permission-fixtures-lint -> nodejs:main Labels test, fast-track, author ready Commits 1 - test: fix permission fixtures lint Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55819 Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55819 Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 11 Nov 2024 17:39:04 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/55819#pullrequestreview-2427864741 ℹ This PR is being fast-tracked ✘ This PR needs to wait 149 more hours to land (or 29 hours if there is one more approval) (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11796935552 |
lpinca
approved these changes
Nov 12, 2024
lpinca
added
commit-queue
|
Landed in bd0c4f8 |
RafaelGSS
added a commit
to nodejs/changelog-maker
that referenced
this pull request
Nov 12, 2024
Fake PR-URL for testing CVE-ID: CVE-2024-22020 PR-URL: nodejs/node#55819
RafaelGSS
added a commit
to nodejs/changelog-maker
that referenced
this pull request
Nov 12, 2024
Fake PR-URL for testing PR-URL: nodejs/node#55819 CVE-ID: CVE-2024-36138
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55819 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #55797 (comment)