Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.18.1 proposal #55879

Open
wants to merge 121 commits into
base: v20.x
Choose a base branch
from
Open

v20.18.1 proposal #55879

wants to merge 121 commits into from

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Nov 16, 2024

2024-11-20, Version 20.18.1 'Iron' (LTS), @marco-ippolito

Notable Changes

Commits

  • [3c073fd595] - assert: show the diff when deep comparing data with a custom message (Giovanni) #54759
  • [24a06083fd] - benchmark: adjust config for deepEqual object (Rafael Gonzaga) #55254
  • [3d3de67b19] - benchmark: rewrite detect-esm-syntax benchmark (Joyee Cheung) #55238
  • [42eb1d65cf] - benchmark: add no-warnings to process.has bench (Rafael Gonzaga) #55159
  • [44df51d3fc] - benchmark: create benchmark for typescript (Marco Ippolito) #54904
  • [9a8900a225] - benchmark: include ascii to fs/readfile (Rafael Gonzaga) #54988
  • [e99c5dbd88] - benchmark: add dotenv benchmark (Aviv Keller) #54278
  • [6b3c24dbad] - buffer: fix out of range for toString (Jason Zhang) #54553
  • [a6784cfaf6] - build: use rclone instead of aws CLI (Michaël Zasso) #55617
  • [799719d458] - build: fix notify-on-review-wanted action (Rafael Gonzaga) #55304
  • [0aaa603fc8] - build: include .nycrc in coverage workflows (Wuli Zuo) #55210
  • [f78d4604a6] - build: notify via slack when review-wanted (Rafael Gonzaga) #55102
  • [698fd484ee] - build: remove -v flag to reduce noise (iwuliz) #55025
  • [f43790bf6b] - build: display free disk space after build in the test-macOS workflow (iwuliz) #55025
  • [b5cd00e33e] - build: add the option to generate compile_commands.json in vcbuild.bat (Segev Finer) #52279
  • [0018cf7e1f] - Revert "build: upgrade clang-format to v18" (Chengzhong Wu) #54994
  • [c707730fbf] - build: print Running XYZ linter... for py and yml (Aviv Keller) #54386
  • [ae34e276a2] - build: pin doc workflow to Node.js 20 (Richard Lau) #55755
  • [fcbdedd2b2] - build,win: add winget config to set up env (Hüseyin Açacak) #54729
  • [45a9d4ac59] - cli: fix spacing for port range error (Aviv Keller) #54495
  • [d45cc45c4a] - Revert "console: colorize console error and warn" (Aviv Keller) #54677
  • [d32cc67fa4] - crypto: ensure invalid SubtleCrypto JWK data import results in DataError (Filip Skokan) #55041
  • [628efe9816] - deps: update undici to 6.20.0 (Node.js GitHub Bot) #55329
  • [c32e10ca86] - deps: upgrade npm to 10.9.0 (npm team) #55255
  • [ae479a8c2d] - deps: update archs files for openssl-3.0.15+quic1 (Node.js GitHub Bot) #55184
  • [a066888c89] - deps: upgrade openssl sources to quictls/openssl-3.0.15+quic1 (Node.js GitHub Bot) #55184
  • [35d9b02663] - deps: update archs files for openssl-3.0.14+quic1 (Node.js GitHub Bot) #54336
  • [aa54fdeae8] - deps: upgrade openssl sources to quictls/openssl-3.0.14+quic1 (Node.js GitHub Bot) #54336
  • [b2f91828b2] - deps: update timezone to 2024b (Node.js GitHub Bot) #55056
  • [d5ecb3c093] - deps: update acorn-walk to 8.3.4 (Node.js GitHub Bot) #54950
  • [704a1e50e6] - deps: update corepack to 0.29.4 (Node.js GitHub Bot) #54845
  • [e4aa929d13] - deps: upgrade npm to 10.8.3 (npm team) #54619
  • [1108c3a7fa] - doc: fix Markdown linter (Antoine du Hamel) #55344
  • [f46f9bf3e7] - Revert "doc: update test context.assert" (Antoine du Hamel) #55344
  • [68b2bc80bf] - doc: add pmarchini to collaborators (Pietro Marchini) #55331
  • [5d95997bd5] - doc: fix events.once() example using AbortSignal (Ivo Janssen) #55144
  • [9986342101] - doc: add onboarding details for ambassador program (Marco Ippolito) #55284
  • [e05192eac2] - doc: fix initial default value of autoSelectFamily (Ihor Rohovets) #55245
  • [d8b32ec51a] - doc: tweak onboarding instructions (Michael Dawson) #55212
  • [f7ca20e5da] - doc: update test context.assert (Pietro Marchini) #55186
  • [744c723b73] - doc: fix unordered error anchors (Antoine du Hamel) #55242
  • [63dbb69542] - doc: mention addons to experimental permission (Rafael Gonzaga) #55166
  • [59de91c467] - doc: use correct dash in stability status (Antoine du Hamel) #55200
  • [3563a3e26a] - doc: fix link in test/README.md (Livia Medeiros) #55165
  • [d4ef374bd2] - doc: add esm examples to node:net (Alfredo González) #55134
  • [fc239a2925] - doc: move the YAML changes element (sendoru) #55112
  • [29177daf82] - doc: fix the require resolve algorithm in modules.md (chirsz) #55117
  • [a953c2201c] - doc: update style guide (Aviv Keller) #53223
  • [ab0ef42957] - doc: add missing : to run()'s globPatterns (Aviv Keller) #55135
  • [7a8992b2d6] - doc: add abmusse to collaborators (Abdirahim Musse) #55086
  • [42515883d2] - doc: add note about --expose-internals (Aviv Keller) #52861
  • [153fcc220e] - doc: remove parseREPLKeyword from REPL documentation (Aviv Keller) #54749
  • [260957f725] - doc: change backporting guide with updated info (Aviv Keller) #53746
  • [9b61b35b88] - doc: add missing definitions to internal-api.md (Aviv Keller) #53303
  • [dfd0318627] - doc: update documentation for externalizing deps (Michael Dawson) #54792
  • [70504f8522] - doc: update require(ESM) history and stability status (Antoine du Hamel) #55199
  • [9d0041ac40] - doc: add release key for aduh95 (Antoine du Hamel) #55349
  • [abf0398b29] - events: allow null/undefined eventInitDict (Matthew Aitken) #54643
  • [62563a0ae7] - events: return currentTarget when dispatching (Matthew Aitken) #54642
  • [c355ae441f] - fs: acknowledge signal option in filehandle.createReadStream() (Livia Medeiros) #55148
  • [b0c8ea3f52] - lib: remove lib/internal/idna.js (Yagiz Nizipli) #55050
  • [1f3435b27d] - lib: the REPL should survive deletion of Array.prototype methods (Jordan Harband) #31457
  • [24474457a9] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #55300
  • [7d8aa7aabb] - meta: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6 (dependabot[bot]) #55225
  • [144d5516db] - meta: bump actions/checkout from 4.1.7 to 4.2.0 (dependabot[bot]) #55224
  • [a88f58d5d0] - meta: bump actions/setup-node from 4.0.3 to 4.0.4 (dependabot[bot]) #55223
  • [23f343571c] - meta: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5 (dependabot[bot]) #55219
  • [56cd9e09de] - meta: add mailmap entry for abmusse (Abdirahim Musse) #55182
  • [08fa713fef] - meta: add more information about nightly releases (Aviv Keller) #55084
  • [375e09d2d3] - meta: add linux to OS labels in collaborator guide (Aviv Keller) #54986
  • [c1a83bd2c4] - meta: remove never-used workflow trigger (Aviv Keller) #54983
  • [9dcdc42afe] - meta: add links to alternative issue trackers (Aviv Keller) #54401
  • [1809f15206] - module: remove duplicated import (Aviv Keller) #54942
  • [e81b089443] - path: remove repetitive conditional operator in posix.resolve (Wiyeong Seo) #54835
  • [a42a1c5945] - perf_hooks: add missing type argument to getEntriesByName (Luke Taher) #54767
  • [5ed58f2c38] - repl: catch \v and \r in new-line detection (Aviv Keller) #54512
  • [5dded54c22] - src: decode native error messages as UTF-8 (Joyee Cheung) #55024
  • [dad5adaf06] - src: update clang-tidy and focus on modernization (Yagiz Nizipli) #53757
  • [5cb2eb131f] - src: cleanup per env handles directly without a list (Chengzhong Wu) #54993
  • [3622c05012] - src: remove duplicate code setting AF_INET (He Yang) #54939
  • [9062137444] - stream: treat null asyncIterator as undefined (Jason Zhang) #55119
  • [8e53245dcc] - test: make test-loaders-workers-spawned less flaky (Antoine du Hamel) #55172
  • [944181ecb7] - test: update multiple assert tests to use node:test (James M Snell) #54585
  • [a02b828ba5] - test: update wpt test for encoding (devstone) #55151
  • [d7b73c5f75] - test: deflake test/pummel/test-timers.js (jakecastelli) #55098
  • [1edbec0aab] - test: deflake test-http-remove-header-stays-removed (Luigi Pinca) #55004
  • [b81e60a5a4] - test: fix test-tls-junk-closes-server (Michael Dawson) #55089
  • [cff8e78f94] - test: fix more tests that fail when path contains a space (Antoine du Hamel) #55088
  • [c3de1e2378] - test: fix assertSnapshot when path contains a quote (Antoine du Hamel) #55087
  • [564f0a3d09] - test: fix some tests when path contains % (Antoine du Hamel) #55082
  • [aa25ef5894] - Revert "test: mark test-fs-watch-non-recursive flaky on Windows" (Luigi Pinca) #55079
  • [6cd773e1f7] - test: make test-runner-assert more robust (Aviv Keller) #55036
  • [9a78418a50] - test: update tls test to support OpenSSL32 (Michael Dawson) #55030
  • [f8dcef4bc4] - test: fix test-vm-context-dont-contextify when path contains a space (Antoine du Hamel) #55026
  • [abb6b30a89] - test: adjust tls-set-ciphers for OpenSSL32 (Michael Dawson) #55016
  • [0df824b685] - test: add util.stripVTControlCharacters test (RedYetiDev) #54865
  • [048c8980a9] - test: improve coverage for timer promises schedular (Aviv Keller) #53370
  • [9359133c38] - test: remove unused common utilities (RedYetiDev) #54825
  • [b247739353] - test: deflake test-http-header-overflow (Luigi Pinca) #54978
  • [cc14622ee3] - test: fix soucre to source (Aviv Keller) #55038
  • [3a6511f675] - test: add asserts to validate test assumptions (Michael Dawson) #54997
  • [3738cea600] - test: move test-http-max-sockets to parallel (Luigi Pinca) #54977
  • [ed4ac2261d] - test: remove test-http-max-sockets flaky designation (Luigi Pinca) #54976
  • [1320c3851b] - test: adjust key sizes to support OpenSSL32 (Michael Dawson) #54972
  • [0173843c66] - test: update test to support OpenSSL32 (Michael Dawson) #54968
  • [6961e4e976] - test: update DOM events web platform tests (Matthew Aitken) #54642
  • [bbdccaa95b] - test_runner: assert entry is a valid object (Edigleysson Silva (Edy)) #55231
  • [276c2e18c1] - test_runner: use test: symbol on second print of parent test (RedYetiDev) #54956
  • [5830931c55] - test_runner: replace ansi clear with ansi reset (Pietro Marchini) #55013
  • [4ab199aa8a] - tools: make choco install script more readable (Aviv Keller) #54002
  • [94a7d82ecd] - tools: bump Rollup from 4.18.1 to 4.22.4 for lint-md (dependabot[bot]) #55093
  • [463b8e556e] - tools: remove redudant code from eslint require rule (Aviv Keller) #54892
  • [11c013b450] - tools: update error message for ICU in license-builder (Aviv Keller) #54742
  • [f650e6ad9d] - tools: update github_reporter to 1.7.1 (Node.js GitHub Bot) #54951
  • [c0de5a1842] - tty: fix links for terminal colors (Aviv Keller) #54596
  • [e012435ab0] - util: update ansi regex (Aviv Keller) #54865
  • [d164bd090c] - watch: preserve output when gracefully restarted (Théo LUDWIG) #54323
  • [a0b71af65e] - worker: throw InvalidStateError in postMessage after close (devstone) #55206
  • [f9744c5e8d] - worker: handle --input-type more consistently (Antoine du Hamel) #54979
  • [85cf69e45e] - zlib: throw brotli initialization error from c++ (Yagiz Nizipli) #54698

aduh95 and others added 30 commits October 11, 2024 10:20
PR-URL: #55349
Refs: nodejs/Release#999
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
To save time, the `.github/workflows/doc.yml` workflow runs
with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has
broken this workflow for Node.js 20 and 18 due to a mismatch
in globals. Pin the version of Node.js back to 20.

PR-URL: #55755
Fixes: #55754
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>
PR-URL: #54553
Backport-PR-URL: #55213
Fixes: #52298
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Refs: #54553
PR-URL: #55199
Backport-PR-URL: #55265
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
PR-URL: #54619
Reviewed-By: Luigi Pinca <[email protected]>
Refs: #54646

- Add instructions to update how process.versions is reported
  as I missed that in a recent addition.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #54792
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
PR-URL: #54951
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54845
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Specifically, `delete Array.prototype.lastIndexOf` immediately crashes
the REPL, as does deletion of a few other Array prototype methods.

PR-URL: #31457
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #54278
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
PR-URL: #54401
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
PR-URL: #53303
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #53746
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54495
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
`AF_INET` has been repeatedly set three times in the code. this should
be redundant. removed the last two times.

PR-URL: #54939
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #54835
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #54642
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mattias Buelens <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
PR-URL: #54642
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Mattias Buelens <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This reverts commit c3e1c31.

PR-URL: #54994
Refs: #53957
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Refs: #53382

This test fails on OpenSSL32 because it complains the key being
used is too short.

It seems to have been missed when the test suite was udpated to have
a Makefile to generate key material as the keys are hard coded in the
test as opposed to being read in from the fixtures/key directory.

Update the test to use keys/certs from the fixtures directory and
to remove newlines at the end of the key and cert to retain the
inteded test.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #54968
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Refs: #53382

This test fails on OpenSSL32 because it complains the key
being used is too short.

Adjust the key sizes so that they will pass on OpenSSL32 in
addition to other OpenSSL3 versions.

Since the keys are not public key related I don't think the
increase in key size will be too bad in terms of performance so
I've just increased versus guarding for OpenSSL32

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #54972
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #54979
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54983
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #54988
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
There is no recent trace of failure for this test.

Fixes: #47116
PR-URL: #54976
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
PR-URL: #54977
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Environment handles can be cleaned up directly without saving the
references in a list and iterate the list.

PR-URL: #54993
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Refs: #54968
Refs: #53382

Add additional asserts as suggestd by Richard in:
#54968

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #54997
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55038
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
dependabot bot and others added 17 commits November 16, 2024 12:41
Bumps [mozilla-actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.5 to 0.0.6.
- [Release notes](https://github.com/mozilla-actions/sccache-action/releases)
- [Commits](Mozilla-Actions/sccache-action@89e9040...9e326eb)

---
updated-dependencies:
- dependency-name: mozilla-actions/sccache-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
PR-URL: #55225
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Specify the initial default value of `autoSelectFamily`
in description of `net.setDefaultAutoSelectFamily()`
as specified in description of `net.getDefaultAutoSelectFamily()`.

PR-URL: #55245
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
PR-URL: #55255
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #55231
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
PR-URL: #55304
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: #55284
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #55300
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #55144
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Syntax detection has been unflagged so it's no longer meaningful
to toggle the detection based on CLI flags. It was also previously
benchmarking cached module imports which isn't very meaningful
for subsequent loads. This patch updates the benchmark to toggle
the detection based on the presence of type field in the package.json,
and generates fixtures to benchmark fresh module loads.

PR-URL: #55238
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Fixes: #55053
PR-URL: #55331
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
This reverts commit 7ddbfe8.

PR-URL: #55344
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55344
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #55329
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
This should make easier to read on benchmark/compare
and when generating graphs

PR-URL: #55254
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Use rclone to upload assets to Cloudflare as it is more reliable.

Refs: nodejs/build#3508
PR-URL: #55617
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Notable changes:

doc:
  * add abmusse to collaborators (Abdirahim Musse) #55086

PR-URL: TODO
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Nov 16, 2024
@marco-ippolito marco-ippolito added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. labels Nov 16, 2024
@marco-ippolito marco-ippolito marked this pull request as ready for review November 16, 2024 13:34
@marco-ippolito marco-ippolito added needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 16, 2024
@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor

aduh95 commented Nov 16, 2024

I think #55170 (comment) is still going to be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.