feat(storybook): viewport #5780
Conversation
Fails of my part
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Im not sure if a plugin is needed for something that can easily be done with a browser viewport functionality.
Im usually against adding extra dependencies, and this one doesn't really briny much value, since browsers can do that by themselves.
There's a reason why I removed this plugin to begin with ;)
I'm neutral to be honest, but any extra dependency we always need to ponder if it's worth it. As it's more install time, more transient and peer dependencies, bigger bundle and more chances of having security issues.
|
I agree with you that it's addictive. 
here's when you use the plugins (it doesn't modify the storybook layout) 
|
|
I can see this being useful for upcoming nav bar work. If you feel really strongly @ovflowd that's fine, but honestly I'm surprised this functionality isn't standard storybook behavior. (We built this into Patternlab.io 7+ years ago) |
|
I steel feel that the Browser DevTools is sufficient. But I dont have strong feelings, feel free to approve and dismiss my review. |
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
Description
Adding of viewport plugins to storybook. It's allow us to see how component will render in different device.
Related Issues
No related issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.