-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: install Storybook addon themes #5785
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
should try not to use decorators in stories. And personally theme switch doesn't work on preview. |
It is based on the collaborator guide
Sorry, I don't get it. Which preview are you referring to? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Clean implementation :)
I'd like to fast-track this as other PRs would definitely benefit from this trivial change. cc @nodejs/nodejs-website |
I mean we should use theme switching on all stories. |
This is already what this changeset does. Or so I believe |
Yes, it changes all stories. You can switch between stories and the themes are the same. |
@HinataKah0 can you run the CI? :) |
I usually let some time passes before merging |
@HinataKah0 Im just asking for you to run the CI pipelines... not to merge the PR |
My bad :) |
Description
Install Storybook's addon
@storybook/addon-themes
and setup light & dark mode in StorybookFollowed this guide
See this comment for context
Validation
Tested locally using
CrossLink
componentRelated Issues
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.