-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avatarGroup): introduce #5916
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'd vote for the two first letters of their github username :) or at your criteria, that's a common pattern and doesn't require us adding yet another img. |
should I use |
done ! And FYI: GitHub add gray octocat if 404. |
I assume Radix UI does that for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you've noticed, Augustin. But you literally reverted my changes. 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've re-added my changes. Please, be more careful next time, Augustin. Pull branches instead of force-pushing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyhow, overall, thank you for your contribution, Augustin! I appreciate your effort here.
As usual, I'd recommend to be more attentive to feedback, and more careful when pushing changes, and be more diligent (self-review) your changes before pushing them 🙇
Description
Introduce
avatarGroup
Validation
Related Issues
Closes #5910
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.