Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avatarGroup): introduce #5916

Merged
merged 33 commits into from
Oct 14, 2023
Merged

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Sep 29, 2023

Description

Introduce avatarGroup

Validation

  • It's should be same as figma
  • If 404 put two charter of "alt props"

Related Issues

Closes #5910

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2023 10:07am

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 96%
95.09% (291/306) 77.77% (56/72) 93.65% (59/63)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 7.89s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Sep 29, 2023

image

This implementation doesn't look right. It would only work if the images are perfect squares.

@ovflowd
Copy link
Member

ovflowd commented Sep 29, 2023

We need to know what if image is 404. This is an illustration I did on figma. So it's not part of the design system

I'd vote for the two first letters of their github username :) or at your criteria, that's a common pattern and doesn't require us adding yet another img.

@AugustinMauroy
Copy link
Member Author

AugustinMauroy commented Sep 30, 2023

This implementation doesn't look right. It would only work if the images are perfect squares.

should I use overflow-hidden?

@AugustinMauroy
Copy link
Member Author

I'd vote for the two first letters of their github username :) or at your criteria, that's a common pattern and doesn't require us adding yet another img.

done ! And FYI: GitHub add gray octocat if 404.

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 30, 2023
@ovflowd
Copy link
Member

ovflowd commented Sep 30, 2023

This implementation doesn't look right. It would only work if the images are perfect squares.

should I use overflow-hidden?

I assume Radix UI does that for you

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you've noticed, Augustin. But you literally reverted my changes. 😞

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-added my changes. Please, be more careful next time, Augustin. Pull branches instead of force-pushing.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyhow, overall, thank you for your contribution, Augustin! I appreciate your effort here.

As usual, I'd recommend to be more attentive to feedback, and more careful when pushing changes, and be more diligent (self-review) your changes before pushing them 🙇

@ovflowd ovflowd added this pull request to the merge queue Oct 14, 2023
Merged via the queue into nodejs:main with commit 4dc0089 Oct 14, 2023
12 checks passed
@AugustinMauroy AugustinMauroy deleted the feat(authors) branch October 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create AvatarGroup Component
3 participants