-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remark-lint, caches and preset-lint-node #6006
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
I want to dig a bit further into https://github.com/nodejs/remark-preset-lint-node before weighing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small question about the persist
keys the in turbo.json
Right, take your time :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate your commitment and drive to get this right, even if we don't always know what that is in the moment. Progress over perfection, and humility to go back and fix things 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR is pretty much (is a second attempt) at working on some of our
remark-lint
rules. (Based on the prior merged PR (#5999), I've realized that not adoptingremark-preset-lint-node
as a "compatibility issue" is an excuse.I've read a few docs and tried to play around with a few things.
turbo.json
, to keep track of every single file does feel like something at best flaky and waiting to break apart..remarkc
that actually explain the misformatting of Frontmatter wheneslint-plugin-mdx
was attempting to run Remark Lint on files. Apparently, just by removingremark-lint-preset-node
, the issue itself wouldn't have been fixed.remark-preset-lint-node
with a few tweaks, such as manually disablingremark-gfm
(as we don't need it) (and apparently on the repository history many eons ago it was at some point disabled). (History often taught us lessons!)eslint
andprettier
caching withmetadata
approach is way faster, apparently on CI it isn't (and actually completely ineffective) due to Git of course not storing timestamp metadata 🤦 (my bad!)This PR in the end ships some CI speed improvements for caching, Better Remark Linting configuration, and enabled Stylelint to also use its cache feature.
Validation
Linting should pass as usual (Note that some files got updated).