Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add openssf badge to new security page #6057

Merged
merged 2 commits into from
Oct 28, 2023
Merged

add openssf badge to new security page #6057

merged 2 commits into from
Oct 28, 2023

Conversation

bmuenzenmeyer
Copy link
Collaborator

Description

Adds the openssf badge to the security page, as all previous conversation has led to.

Validation

image

Related Issues

closes #5432
supercedes #6030

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner October 27, 2023 12:23
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 4:34am

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
95% (304/320) 76.38% (55/72) 93.84% (61/65)

Unit Test Report

Tests Skipped Failures Errors Time
38 0 💤 0 ❌ 0 🔥 7.836s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Oct 27, 2023

The current position of the badge feels ugly/weird. Maybe after the first paragraph?

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM But what do you thinks about disable hover on badge ?

@ovflowd
Copy link
Member

ovflowd commented Oct 28, 2023

SGTM But what do you thinks about disable hover on badge ?

I think we can ignore for now, as the designs are going to change.

@ovflowd ovflowd added this pull request to the merge queue Oct 28, 2023
Merged via the queue into main with commit d0ed15c Oct 28, 2023
12 checks passed
@ovflowd ovflowd deleted the openssf-badge branch October 28, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CII Best practices badge addition
4 participants