Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: updated all markdown files metadata and updated files to be ready for translation #6058

Merged
merged 14 commits into from
Oct 28, 2023
Merged

meta: updated all markdown files metadata and updated files to be ready for translation #6058

merged 14 commits into from
Oct 28, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 27, 2023 •
edited
Loading

Description

This PR normalises Markdown files and prepares certain contents for translation.

  • All the blog pages were reformatted and had their Markdown frontmatter updated, removing obsolete frontmatter variables.
  • Some pages, such as the Home Page, Docs Index had their content extracted directly to Markdown
  • MDX Components got directly extracted to a separated next.mdx.use.mjs to define all shared MDX Components and HTML wirings
  • Updated some translation keys and crowdin configuration
  • Updated internal links using https://nodejs.org or /en/ to use simple / as we now prepend the current language.

Validation

Pages should be behaving and rendering as expected.

Related Issues

Relates to #6036

@ovflowd ovflowd requested review from a team as code owners October 27, 2023 13:48
@vercel
Copy link

vercel bot commented Oct 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 10:00am

@github-actions
Copy link

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@ovflowd ovflowd changed the title Refactor/updated-source-markdown-metadatas meta: updated all markdown files metadata and updated files to be ready for translation Oct 27, 2023
@ovflowd ovflowd added i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra github_actions:pull-request Trigger Pull Request Checks labels Oct 27, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@github-actions
Copy link

github-actions bot commented Oct 27, 2023 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 95%
 95.41% (333/349) 77.21% (61/79) 93.05% (67/72)

Unit Test Report

Tests Skipped Failures Errors Time
42 0 💤 0 ❌ 0 🔥 6.65s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 27, 2023
@ovflowd ovflowd force-pushed the refactor/updated-source-markdown-metadatas branch from fa4ce38 to 37f51fe Compare October 28, 2023 09:59
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 28, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 28, 2023
@github-actions
Copy link

github-actions bot commented Oct 28, 2023 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 95 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 92 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 91 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 92 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 92 🟢 92 🟢 92 🔗

@ovflowd ovflowd added this pull request to the merge queue Oct 28, 2023
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Oct 28, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Oct 28, 2023

I'm fast-tracking this as it is mostly metadata update and fixing links. I've verified that links are working as much as I could... But @bmuenzenmeyer we might want to add a link checker workflow to run on main from time to time just to verify links are not broken.

Merged via the queue into main with commit a5906c7 Oct 28, 2023
23 checks passed
@ovflowd ovflowd deleted the refactor/updated-source-markdown-metadatas branch October 28, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs i18n Issues/PRs related to the Website Internationalisation infrastructure Issues/PRs related to the Repository Infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ovflowd @targos @AugustinMauroy