-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(learn): migrate "How to publish N-API package" guide to the learn section #6232
docs(learn): migrate "How to publish N-API package" guide to the learn section #6232
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cc @nodejs/n-api-admins and @nodejs/node-api can y'all proofcheck this PR and verify it is still relevant and correct? |
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Running prettier will help get CI to pass
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Mwelwa <[email protected]>
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Mwelwa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting is good
I can confirm the doc is still relevant and the rename from n-api to node-api looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- any concern on the age of the example? it's archived
- also, node-api is no longer experimental
some small grammar nits which i will resolve here
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@ovflowd Can we remove nodejs/collaborators from code owners, since it tags all collaborators on every pull request? |
It's intentional since this content (the learn content) is owned by Core Collaborators. Someone needs to own the content... |
Subject: Request for Redirect Link Update in Merged PR Hi , I've noticed an issue with the merged pull request in the |
Description
This PR migrates the legacy guide "How to publish N-API package" to the learn section and also renames occurrences of
N-API
toNode-API
as the preferred term according to https://nodejs.org/api/n-api.html#:~:text=Node%2DAPI%20(formerly%20N%2D,jsValidation
Related Issues
Fixes #6229
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.