-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(learn): Migrate "Anatomy of an http transaction" guide to the learn section #6256
docs(learn): Migrate "Anatomy of an http transaction" guide to the learn section #6256
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General review:
- on code block we should use
js
instead ofjavascript
for language définition - when a code snippet import a nodejs internal package we should use the
node:
like in api docs
Just a question: should you put the contents in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
i noticed more than 45 files use |
i make a change on the snippets to import from |
I think just making the file you're on would be great.
Right ! FYI all internal node module can be import with |
awesome, worked on the issues |
…definition change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@bmuenzenmeyer you would review this pr because it was you who opened the issue |
i wouldnt be surprised if we moved some of these modules around after we see the full picture |
Description
This PR migrates the
Anatomy of an http transaction
guide to the learn sectionValidation
Related Issues
Fixes #6226
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.