-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Orama for search #6257
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm extremely supportive of this. Nice job @micheleriva!
Broken Orama logo is fixed as well! I may need support for Windows scroll bars. I don't have a Windows machine for testing :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the showstopping issue look resolved to me. nice work @micheleriva VERY EXCITED ABOUT THIS
@ovflowd how do you feel about merging this now? |
Hey, @bmuenzenmeyer I'm going to give a final pass this weekend, including possible any bug fixes or UI fixes that I deem appropriate, and then we're good to merge! |
I apologize for not being active here; these last two weeks at work have been... Extreme. |
I've fixed all issues cosmetic and functional ones. I think we're ready to ship this. A review is appreciated cc @nodejs/nodejs-website |
Description
As discussed with @ovflowd, I'm opening this PR to add support for full-text and AI search to the new Node.js website via Orama Cloud.
Missing parts:
/search
pageSearchBox
component into multiple, smaller componentsValidation
I'd really appreciate @ovflowd or any other contributor to test this and provide feedback.
Please note this is still a work in progress and it's not ready for merge or final review.Related Issues
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.