Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Orama for search #6257

Merged
merged 53 commits into from
Feb 23, 2024
Merged

Integrate Orama for search #6257

merged 53 commits into from
Feb 23, 2024

Conversation

micheleriva
Copy link
Contributor

@micheleriva micheleriva commented Jan 19, 2024

Description

As discussed with @ovflowd, I'm opening this PR to add support for full-text and AI search to the new Node.js website via Orama Cloud.

Missing parts:

  • Manage texts via i18n system
  • Write /search page
  • Enhance mobile version
  • Index Node.js APIs too (@ovflowd I'll need your APIs here, but no hurry)
  • Split SearchBox component into multiple, smaller components
  • Add GitHub workflow for redeploying the index

Validation

I'd really appreciate @ovflowd or any other contributor to test this and provide feedback. Please note this is still a work in progress and it's not ready for merge or final review.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 9:10pm

components/SearchBox/components/EmptyState.tsx Outdated Show resolved Hide resolved
components/SearchBox/components/NoResults.tsx Outdated Show resolved Hide resolved
components/SearchBox/components/NoResults.tsx Outdated Show resolved Hide resolved
components/SearchBox/components/PoweredBy.tsx Outdated Show resolved Hide resolved
components/SearchBox/components/PoweredBy.tsx Outdated Show resolved Hide resolved
components/SearchBox/index.tsx Outdated Show resolved Hide resolved
components/SearchBox/index.tsx Outdated Show resolved Hide resolved
components/SearchBox/lib/useClickOutside.ts Outdated Show resolved Hide resolved
components/SearchBox/lib/useClickOutside.ts Outdated Show resolved Hide resolved
components/SearchBox/lib/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm extremely supportive of this. Nice job @micheleriva!

@micheleriva
Copy link
Contributor Author

Broken Orama logo is fixed as well! I may need support for Windows scroll bars. I don't have a Windows machine for testing :(

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the showstopping issue look resolved to me. nice work @micheleriva VERY EXCITED ABOUT THIS

@bmuenzenmeyer
Copy link
Collaborator

@ovflowd how do you feel about merging this now?

@ovflowd
Copy link
Member

ovflowd commented Feb 23, 2024

@ovflowd how do you feel about merging this now?

Hey, @bmuenzenmeyer I'm going to give a final pass this weekend, including possible any bug fixes or UI fixes that I deem appropriate, and then we're good to merge!

@ovflowd
Copy link
Member

ovflowd commented Feb 23, 2024

I apologize for not being active here; these last two weeks at work have been... Extreme.

@ovflowd ovflowd added website redesign Issue/PR part of the Node.js Website Redesign github_actions:pull-request Trigger Pull Request Checks labels Feb 23, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 23, 2024
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 23, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 23, 2024
@ovflowd
Copy link
Member

ovflowd commented Feb 23, 2024

I've fixed all issues cosmetic and functional ones. I think we're ready to ship this. A review is appreciated cc @nodejs/nodejs-website

@ovflowd ovflowd added this pull request to the merge queue Feb 23, 2024
Merged via the queue into nodejs:main with commit a98c1cd Feb 23, 2024
16 checks passed
@ovflowd ovflowd deleted the feat/integrate-orama branch February 23, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants