Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: add february 2024 security release announcement #6268

Merged
merged 1 commit into from
Jan 30, 2024
Merged

blog: add february 2024 security release announcement #6268

merged 1 commit into from
Jan 30, 2024

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS requested a review from a team as a code owner January 30, 2024 14:44
@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 3:02pm

@RafaelGSS
Copy link
Member Author

cc: @nodejs/security @nodejs/tsc

@RafaelGSS RafaelGSS added the github_actions:pull-request Trigger Pull Request Checks label Jan 30, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 98 🟠 83 🟢 91 🔗
/en/about 🟢 100 🟢 98 🟠 83 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟠 83 🟢 91 🔗
/en/blog 🟢 100 🟢 98 🟠 83 🟢 92 🔗

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
 85.89% (402/468) 77.16% (125/162) 77.52% (69/89)

Unit Test Report

Tests Skipped Failures Errors Time
72 0 💤 0 ❌ 0 🔥 4.569s ⏱️

@RafaelGSS RafaelGSS mentioned this pull request Jan 30, 2024
Closed
mcollina
mcollina approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RafaelGSS RafaelGSS added the github_actions:pull-request Trigger Pull Request Checks label Jan 30, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 30, 2024
mhdawson
mhdawson approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@nodejs/nodejs-website seems like an approval is needed.

@RafaelGSS RafaelGSS added this pull request to the merge queue Jan 30, 2024
@ovflowd
Copy link
Member

ovflowd commented Jan 30, 2024

Shouldnt the blog post mention which issues the security release are addressing? Like the CVEs?

Merged via the queue into main with commit 1c530cb Jan 30, 2024
16 checks passed
@RafaelGSS RafaelGSS deleted the pre-sec-release-feb-24 branch January 30, 2024 16:00
@richardlau
Copy link
Member

Shouldnt the blog post mention which issues the security release are addressing? Like the CVEs?

That's done in a follow up update when the releases are released to avoid premature disclosure.

@richardlau
Copy link
Member

richardlau commented Jan 30, 2024 •
edited
Loading

Should this have also updated the banner on the website?

@ovflowd
Copy link
Member

ovflowd commented Jan 30, 2024

Should this have also updated the banner on the website?

I dont see a file change for banners. But probably yes.

richardlau added a commit that referenced this pull request Feb 1, 2024
@richardlau
meta: add banner for 6 February 2024 security releases
f0b4773 
Refs: #6268
@richardlau richardlau mentioned this pull request Feb 1, 2024
Merged
4 tasks
@richardlau
Copy link
Member

Should this have also updated the banner on the website?

I dont see a file change for banners. But probably yes.

Opened #6270

richardlau added a commit that referenced this pull request Feb 1, 2024
@richardlau
meta: add banner for 6 February 2024 security releases
d1922d2 
Refs: #6268
github-merge-queue bot pushed a commit that referenced this pull request Feb 3, 2024
@richardlau
meta: add banner for 6 February 2024 security releases (#6270)
3fc1656 
Refs: #6268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canerakdas canerakdas canerakdas approved these changes

@ovflowd ovflowd ovflowd approved these changes

@mhdawson mhdawson mhdawson approved these changes

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RafaelGSS @mhdawson @ovflowd @richardlau @mcollina @anonrig @canerakdas