Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(learn): Migrate the legacy guide "Easy profiling for Node.js Applications" to the learn section #6336

Merged
merged 11 commits into from
Feb 14, 2024

Conversation

byt3h3ad
Copy link
Contributor

@byt3h3ad byt3h3ad commented Feb 11, 2024

Description

Migrated the legacy guide "Easy profiling for Node.js Applications" to the learn section.

Validation

image

Related Issues

Fixes #6220

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 10:58am

@byt3h3ad byt3h3ad changed the title Migration docs(learn): Migrate the legacy guide "Easy profiling for Node.js Applications" to the learn section Feb 11, 2024
navigation.json Outdated Show resolved Hide resolved
@ovflowd
Copy link
Member

ovflowd commented Feb 12, 2024

I see the PR is still a draft, but don't forget to also add a redirect.json entry for this guide :)

@byt3h3ad
Copy link
Contributor Author

hey @ovflowd i have made all the changes requested. sorry for the delay!

Signed-off-by: Claudio W <[email protected]>
Signed-off-by: Claudio W <[email protected]>
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@ovflowd
Copy link
Member

ovflowd commented Feb 14, 2024

Thanks for the contribution :)

Copy link

github-actions bot commented Feb 14, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 99 🟠 83 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟠 83 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟠 83 🟢 92 🔗

Copy link

github-actions bot commented Feb 14, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
85.89% (402/468) 77.16% (125/162) 77.52% (69/89)

Unit Test Report

Tests Skipped Failures Errors Time
72 0 💤 0 ❌ 0 🔥 4.623s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Feb 14, 2024
@ovflowd ovflowd added this pull request to the merge queue Feb 14, 2024
Merged via the queue into nodejs:main with commit 03d1198 Feb 14, 2024
16 checks passed
@byt3h3ad byt3h3ad deleted the migration branch February 16, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate the legacy guide "Easy profiling for Node.js Applications" to the learn section
3 participants