fix(minor): Bash script on downloads page uses a command that is not installed on Mac #6343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
|
any reasons why this pr is on draft ? |
Unit Test Coverage Report
Unit Test Report
|
First PR on a major repository (not first PR overall) so I didn't want to make a dumb mistake. Gonna hit the "Ready for review" button. |
AugustinMauroy
approved these changes
Feb 14, 2024
focarroll
changed the title
aymen94
approved these changes
Feb 15, 2024
…being downloaded to the wrong location
|
That's embarrassing... I made a minor edit to the command when running it on my computer, but never changed the file before pushing. |
|
... |
|
All good :) |
ovflowd
approved these changes
Feb 16, 2024
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I made this issue (#3758) about three years ago and then forgot about it. Not knowing how to fix it, I left the solution as a comment and hoped someone would figure it out. Today, I received two emails about comments reminding me about this minor issue. Now knowing a bit more about Git, I've decided that it's finally time to put this issue to rest.
So long...
(this description is longer than the fix lol)
Validation
The package was downloaded and successfully installed to /usr/local/bin. Running node -v confirmed that v21.6.2 was installed.
Related Issues
Fixes #3758
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.