Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase coverage #6349

Merged
merged 34 commits into from
Apr 1, 2024
Merged

test: Increase coverage #6349

merged 34 commits into from
Apr 1, 2024

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Feb 17, 2024

Description

Goal, increase test coverage.

Area concerned:

  • util/
  • hooks/
  • 🆗 next-data/ some have been tested, but not all
  • providers/

Validation

All test should pass.

Related Issues

No related issue.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Feb 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 11:24am

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved
Co-authored-by: Claudio W <[email protected]>
Signed-off-by: Augustin Mauroy <[email protected]>
Copy link

github-actions bot commented Mar 22, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
89.68% (574/640) 75.1% (175/233) 91.4% (117/128)

Unit Test Report

Tests Skipped Failures Errors Time
120 0 💤 0 ❌ 0 🔥 5.506s ⏱️

@AugustinMauroy
Copy link
Member Author

Holy moly macaroni, Ci is green again (can't wait to leave jest)
@nodejs/nodejs-website you can review now

@ovflowd

This comment was marked as resolved.

@AugustinMauroy

This comment was marked as resolved.

@ovflowd

This comment was marked as resolved.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the Special H1 Story doesn't seem correctly styled. Besides that LGTM.

@ovflowd ovflowd added this pull request to the merge queue Apr 1, 2024
@ovflowd
Copy link
Member

ovflowd commented Apr 1, 2024

(You can address that on a follow-up PR)

Merged via the queue into main with commit c3f9c12 Apr 1, 2024
15 checks passed
@ovflowd ovflowd deleted the increase-test branch April 1, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants