-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(learn): migrate the backpressuring-in-streams from guide to learn section #6352
doc(learn): migrate the backpressuring-in-streams from guide to learn section #6352
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
Lifecycle of |
Hi @AugustinMauroy, I was wondering if we could handle this in a separated issue, because it seems to be something related to the width of the Another issue about ASCII art was already fixed on this issue #6337. Running locally and checking the preview, the ASCII art is ok for some specific screen sizes: I guess we need to make some changes on That's why I think it would be better to handle this in another issue. What do you think? |
The ASCII itself is rendering fine, the issue is just "screen sizes" and that shouldn't be fixed in this PR nor in any PR. This artifact happens due to us not allowing scrolling on CodeBoxes. We enforce line-breaks. |
Yet if you feel this is something you'd like to tackle on a separated PR, feel free :) |
One solution I came up with was to use illustrations instead of ASCII art. |
That's not a solution, that is a downgrade. Images are heavier, take time to load, have fixed sizes, meaning that they will eventually be hard to see depending of screen size. The ASCII arts work well, it's just, these were not designed to be read from a phone. |
@AugustinMauroy regarding the link to the Rodd Vagg blog [https://r.va.gg/2014/06/why-i-dont-use-nodes-core-stream-module.html]. It's working fine when I tested. You said on the #6261 review , that it is a death link. What do you mean? Is it not necessary anymore in this migration? Thank you. |
@ovflowd Yes true image isn't good idea. @paulobelucci cool that no more 404. IDK why I had a 404 but good news |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 !!!
All is good if ascii art is not care about
Co-authored-by: Augustin Mauroy <[email protected]> Signed-off-by: Paulo Belucci <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome contribution! Thank you so much, @paulobelucci!
Not sure what's going on with the Vercel deployment but otherwise this looks good - nice work |
Can I do something to help on this Vercel deploy issue? some commit to trigger the pipeline again or something like that? |
Not really, something I need to check. Redeploying 👀 |
In the redirection file, I found trailing slashes at the end of the source or destination |
Description
This PR:
Module-related guides
and the link [Backpressuring in Streams] from the guides sectionnode:
on the require for internal packageshttps://r.va.gg/2014/06/why-i-dont-use-nodes-core-stream-module.html
death linkhttp://dtrace.org/blogs/about/
tohttps://dtrace.org/about/
Validation
Related Issues
#6228
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.