feat(accent color): use color of navBar
#6391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AugustinMauroy
changed the title
navBar
|
@AugustinMauroy how does it look with the dark mode? |
ovflowd
approved these changes
Mar 2, 2024
ovflowd
reviewed
Mar 2, 2024
PR description has been update with all theme |
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Can we make dark theme to match the actual header colour? |
Unit Test Coverage Report
Unit Test Report
|
My bad. it's not the right sceenshot if you thake a look it's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that on Safari, the header/tabs was gray-black because our accent color was
#333, so I set it to the color of thenavbarcomponent because it matches perfectly. Question, should we usegenerateViewport?Before:
Light
dark
After:
Light
dark
Related Issues
No Related Issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.