-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: download button icon #6395
Conversation
Signed-off-by: heygsc <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm not fan of this icon we should use same icon as download page. import { CloudArrowDownIcon } from '@heroicons/react/24/outline'; |
Signed-off-by: heygsc <[email protected]>
It makes sense. |
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM ! Thanks for your first contribution 🎉
Thank you! |
FYI if you add "closes #6392" to the PR description it will show up as a relevant PR in the issue itself and automatically close the issue when the PR is merged. (Prevents confusion like this: #6392 (comment).) |
FYI, can we swap the icon to before the text? For the arrow, it made sense to be on the right, not for this icon anymore. |
I kinda think on the right makes sense? |
Why so? (Out of curiosity) |
Okay, I didn't carefully check the issue before, but now it has been added to the description. |
To the right, is it to point to the "download" text? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the PR 🌟
Description
Before the download button, it was pointed to the right, but changed to downward, which is in line with the meaning of downloading.
Validation
Related Issues
fix: #6392
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.