Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(learn): add article for publishing a typescript package #7279

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

JakobJingleheimer
Copy link
Member

@JakobJingleheimer JakobJingleheimer commented Nov 23, 2024

Description

Document the recommended way to publish a typescript package

Validation

Related Issues

nodejs/typescript#19

Depends on #7229

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copy link

vercel bot commented Nov 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Feb 4, 2025 10:19am

@AugustinMauroy
Copy link
Member

AugustinMauroy commented Dec 29, 2024

Jacob you should:

apps/site/pages/en/learn/typescript/publishing.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/publishing.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/publishing.md Outdated Show resolved Hide resolved
apps/site/pages/en/learn/typescript/publishing.md Outdated Show resolved Hide resolved
@JakobJingleheimer

This comment was marked as outdated.

Co-authored-by: Augustin Mauroy <[email protected]>
Signed-off-by: Jacob Smith <[email protected]>
@JakobJingleheimer JakobJingleheimer marked this pull request as ready for review January 8, 2025 19:20
@JakobJingleheimer JakobJingleheimer requested a review from a team as a code owner January 8, 2025 19:20
@JakobJingleheimer

This comment was marked as resolved.

@AugustinMauroy

This comment was marked as resolved.

@JakobJingleheimer

This comment was marked as resolved.

@AugustinMauroy
Copy link
Member

Bump for codetab, I'll open an issue because it's an error on our side not on shiky or your docs

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to mention that ts target allow the user to support "old" js version.

@JakobJingleheimer
Copy link
Member Author

Also need to mention that ts target allow the user to support "old" js version.

Good point! What ES version does node 18 support? I think probably es2022? https://compat-table.github.io/compat-table/es2016plus/#node16_11

@ljharb
Copy link
Member

ljharb commented Feb 3, 2025

It's not a clean mapping; unfortunately TS doesn't have a babel-preset-env-like setting where it can infer the parser settings from your supported envs.

@JakobJingleheimer
Copy link
Member Author

It's not a clean mapping; unfortunately TS doesn't have a babel-preset-env-like setting where it can infer the parser settings from your supported envs.

Looks like there is something: https://www.typescriptlang.org/tsconfig/#targethttps://www.npmjs.com/package/@tsconfig/node18

@ljharb
Copy link
Member

ljharb commented Feb 3, 2025

That's great, thanks!

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!! WOW after some interation

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 88 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
83.85% (587/700) 64.74% (180/278) 82.7% (110/133)

Unit Test Report

Tests Skipped Failures Errors Time
123 0 💤 0 ❌ 0 🔥 4.956s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.