Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: implement R2Provider #116

Merged
merged 1 commit into from
Apr 24, 2024
Merged

src: implement R2Provider #116

merged 1 commit into from
Apr 24, 2024

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Apr 14, 2024

Adds the Provider interface and most of the implementation of R2Provider as discussed in #111. Note that as of right now the provider isn't being used, this will happen in future prs.

@flakey5 flakey5 requested a review from a team as a code owner April 14, 2024 19:17
@flakey5 flakey5 force-pushed the flakey5/20240405/provider branch 2 times, most recently from 694e775 to 2b6d1d3 Compare April 14, 2024 21:00
@flakey5 flakey5 requested a review from a team as a code owner April 14, 2024 21:00
Adds the Provider interface and most of the implementation of R2Provider as discussed in #111. Note that as of right now the provider isn't being used, this will happen in future prs.
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flakey5 flakey5 merged commit 6dfd9f3 into main Apr 24, 2024
3 checks passed
@flakey5 flakey5 deleted the flakey5/20240405/provider branch April 24, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants