Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: rework mapBucketPathToUrlPath to work better with the redirects #49

Merged
merged 2 commits into from
Oct 19, 2023
Merged

src: rework mapBucketPathToUrlPath to work better with the redirects #49

merged 2 commits into from
Oct 19, 2023

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Oct 16, 2023

No description provided.

@flakey5 flakey5 requested a review from a team as a code owner October 16, 2023 03:01
ovflowd
ovflowd reviewed Oct 16, 2023
View reviewed changes
src/util.ts Show resolved Hide resolved
@MoLow
Copy link
Member

MoLow commented Oct 16, 2023

is this PR only about the cache purge, or also handling the actual requests?

@flakey5
Copy link
Member Author

flakey5 commented Oct 16, 2023

is this PR only about the cache purge, or also handling the actual requests?

Cache purge only

MoLow
MoLow reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please adjust tests as well

@ovflowd ovflowd merged commit 891f9a5 into main Oct 19, 2023
3 checks passed
@ovflowd ovflowd deleted the flakey5/20231015/cache-purge-redirects branch October 19, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd left review comments

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flakey5 @MoLow @ovflowd