fix: make redirects work as intended #52
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #50 showed that redirects aren't working properly. They go off of the url's path, which introduces a couple of problems. For example, when testing
/dist/latest-v20.x
, the worker checks ifnodejs/dist/latest/v20.x
is in theREDIRECT_MAP
object.This is in a pretty rough testing state still, but I wanted to open the conversation on this and the approach we want to take
I got rewrites working but it's not exactly nice (see diff). There are a few takeaways I got from tinkering that I think we should keep in mind:
REDIRECT_MAP
rather than checking for the url (eliminates possibility of looking for redirects for paths such asnodejs/dist/...
)/download/release/latest/
or/docs/latest
or/api
.The code in the diff is working and something we could go with, but I wanted to get others' opinions on it and any other possible approaches before opening it for review.
Fixes #50