Code

feat: implement websockets#1795

Code

Merged

KhafraDev merged 82 commits intonodejs:mainnodejs/undici:mainfrom KhafraDev:wsKhafraDev/undici:wsCopy head branch name to clipboardDec 16, 2022

+3,882-16

Commits

Commits on Nov 28, 2022

• initial handshake

  KhafraDev

  committed
  bb688ac

  Copy full SHA for bb688ac

Commits on Nov 29, 2022

• minor fixes

  KhafraDev

  committed
  e6e2686

  Copy full SHA for e6e2686

Commits on Dec 1, 2022

• feat: working initial handshake!

  KhafraDev

  committed
  9aea277

  Copy full SHA for 9aea277

• feat(ws): initial WebSocket class implementation

  KhafraDev

  committed
  f1ae69a

  Copy full SHA for f1ae69a

• fix: allow http: and ws: urls

  KhafraDev

  committed
  bec82fd

  Copy full SHA for bec82fd

• fix(ws): use websocket spec

  KhafraDev

  committed
  7e6725e

  Copy full SHA for 7e6725e

• fix(ws): use websocket spec

  KhafraDev

  committed
  5030683

  Copy full SHA for 5030683

• feat: implement url getter

  KhafraDev

  committed
  a928c58

  Copy full SHA for a928c58

• feat: implement some of WebSocket.close and ready state

  KhafraDev

  committed
  ecff3d7

  Copy full SHA for ecff3d7

• fix: body is null for websockets & pass socket to response

  KhafraDev

  committed
  6ec2701

  Copy full SHA for 6ec2701

• fix: store the fetch controller & response on ws

  KhafraDev

  committed
  39c7b43

  Copy full SHA for 39c7b43

• fix: remove invalid tests

  KhafraDev

  committed
  fb84cb8

  Copy full SHA for fb84cb8

Commits on Dec 2, 2022

• feat: implement readyState getter

  KhafraDev

  committed
  85a4046

  Copy full SHA for 85a4046

• feat: implement protocol and extensions getters

  KhafraDev

  committed
  190cabe

  Copy full SHA for 190cabe

• feat: implement event listeners

  KhafraDev

  committed
  454a5c3

  Copy full SHA for 454a5c3

• feat: implement binaryType attribute

  KhafraDev

  committed
  5ae04ee

  Copy full SHA for 5ae04ee

• fix: add argument length checks

  KhafraDev

  committed
  c9ff83a

  Copy full SHA for c9ff83a

• feat: basic unfragmented message parsing

  KhafraDev

  committed
  484e732

  Copy full SHA for 484e732

Commits on Dec 3, 2022

• fix: always remove previous listener

  KhafraDev

  committed
  8619653

  Copy full SHA for 8619653

• feat: add in idlharness WPT

  KhafraDev

  committed
  c70bd8b

  Copy full SHA for c70bd8b

Commits on Dec 4, 2022

• implement sending a message for WS and add a websocketFrame class

  jodevsa

  committed
  34758e6

  Copy full SHA for 34758e6

• Merge pull request #30 from jodevsa/ws

  Show description for 6a6b1b3
  KhafraDev

  authored
  6a6b1b3

  Copy full SHA for 6a6b1b3

• feat: allow sending ArrayBuffer/Views & Blob

  KhafraDev

  committed
  a87e53b

  Copy full SHA for a87e53b

• fix: remove duplicate upgrade and connection headers

  KhafraDev

  committed
  d983115

  Copy full SHA for d983115

• feat: add in WebSocket.close() and handle closing frames

  KhafraDev

  committed
  feee358

  Copy full SHA for feee358

• refactor WebsocketFrame and support receiving frames in multiple chunks

  jodevsa

  committed
  5e61a84

  Copy full SHA for 5e61a84

• fixes

  jodevsa

  committed
  0e07468

  Copy full SHA for 0e07468

Commits on Dec 5, 2022

• Merge pull request #31 from jodevsa/ws

  Show description for e288ea5
  KhafraDev

  authored
  e288ea5

  Copy full SHA for e288ea5

• move WebsocketFrame to its own file

  KhafraDev

  committed
  cbad426

  Copy full SHA for cbad426

• feat: export WebSocket & add types

  KhafraDev

  committed
  d2462a1

  Copy full SHA for d2462a1

• fix: tsd

  KhafraDev

  committed
  1340dd4

  Copy full SHA for 1340dd4

• feat(wpt): use WebSocketServer & run test

  KhafraDev

  committed
  8d98382

  Copy full SHA for 8d98382

• fix: properly set/read close code & close reason

  KhafraDev

  committed
  3cae2ec

  Copy full SHA for 3cae2ec

Commits on Dec 6, 2022

• fix: flakiness in websocket test runner

  KhafraDev

  committed
  73c8389

  Copy full SHA for 73c8389

• fix: receive message with arraybuffer binary type

  KhafraDev

  committed
  8b7bc44

  Copy full SHA for 8b7bc44

• feat: split WebsocketFrame into 2 classes (sent & received)

  KhafraDev

  committed
  eb09dc6

  Copy full SHA for eb09dc6

• fix: parse fragmented frames more efficiently & close frame

  KhafraDev

  committed
  174c030

  Copy full SHA for 174c030

• fix: add types for MessageEvent and CloseEvent

  KhafraDev

  committed
  7ee907b

  Copy full SHA for 7ee907b

• fix: subprotocol validation & add wpts

  KhafraDev

  committed
  6985bc3

  Copy full SHA for 6985bc3

Commits on Dec 7, 2022

• fix: protocol validation & protocol webidl & add wpts

  KhafraDev

  committed
  eae7f76

  Copy full SHA for eae7f76

• fix: correct bufferedAmount calc. & message event w/ blob

  KhafraDev

  committed
  682d880

  Copy full SHA for 682d880

• fix: don't truncate typedarrays

  KhafraDev

  committed
  052a804

  Copy full SHA for 052a804

• feat: add remaining wpts

  KhafraDev

  committed
  5f2fdab

  Copy full SHA for 5f2fdab

• fix: allow sending payloads > 65k bytes

  KhafraDev

  committed
  6caaa47

  Copy full SHA for 6caaa47

• fix: mask data > 125 bytes properly

  KhafraDev

  committed
  2d5b9ae

  Copy full SHA for 2d5b9ae

• revert changes to core

  KhafraDev

  committed
  0880cef

  Copy full SHA for 0880cef

Commits on Dec 8, 2022

• fix: decrement bufferedAmount after write

  KhafraDev

  committed
  02805e8

  Copy full SHA for 02805e8

• fix: handle ping and pong frames

  KhafraDev

  committed
  58114ab

  Copy full SHA for 58114ab

• fix: simplify receiving frame logic

  KhafraDev

  committed
  a099471

  Copy full SHA for a099471

Commits on Dec 9, 2022

• fix: disable extensions & validate frames

  KhafraDev

  committed
  346bdb8

  Copy full SHA for 346bdb8

• fix: send close frame upon receiving

  KhafraDev

  committed
  5113fb2

  Copy full SHA for 5113fb2

• lint

  KhafraDev

  committed
  dee913c

  Copy full SHA for dee913c

• fix: validate status code & utf-8

  KhafraDev

  committed
  b3c4314

  Copy full SHA for b3c4314

• fix: add hooks

  KhafraDev

  committed
  7741277

  Copy full SHA for 7741277

• fix: check if frame is unfragmented correctly

  KhafraDev

  committed
  b1339fb

  Copy full SHA for b1339fb

Commits on Dec 10, 2022

• fix: send ping app data in pong frames

  KhafraDev

  committed
  61c921c

  Copy full SHA for 61c921c

• export websocket on node >= 18 & add diagnostic_channels

  KhafraDev

  committed
  c7249d3

  Copy full SHA for c7249d3

• mark test as flaky

  KhafraDev

  committed
  aadf25a

  Copy full SHA for aadf25a

• fix: couple bug fixes

  KhafraDev

  committed
  30b1e23

  Copy full SHA for 30b1e23

• fix: fragmented frame end detection

  KhafraDev

  committed
  6a7134b

  Copy full SHA for 6a7134b

Commits on Dec 11, 2022

• fix: use TextDecoder for utf-8 validation

  KhafraDev

  committed
  b6411a6

  Copy full SHA for b6411a6

• fix: handle incomplete chunks

  KhafraDev

  committed
  4fbfbf4

  Copy full SHA for 4fbfbf4

• revert: handle incomplete chunks

  KhafraDev

  committed
  e43fa5b

  Copy full SHA for e43fa5b

• mark WebSockets as experimental

  KhafraDev

  committed
  553a0f2

  Copy full SHA for 553a0f2

• fix: sending 65k bytes is still flaky on linux

  KhafraDev

  committed
  e0289f7

  Copy full SHA for e0289f7

• fix: apply suggestions

  KhafraDev

  committed
  dcc3801

  Copy full SHA for dcc3801

Commits on Dec 12, 2022

• fix: apply some suggestions

  KhafraDev

  committed
  797acc3

  Copy full SHA for 797acc3

• add basic docs

  KhafraDev

  committed
  dfc57ab

  Copy full SHA for dfc57ab

Commits on Dec 13, 2022

• feat: use streaming parser for frames

  KhafraDev

  committed
  a0094a4

  Copy full SHA for a0094a4

• feat: validate some frames & remove WebsocketFrame class

  KhafraDev

  committed
  883d9d9

  Copy full SHA for 883d9d9

Commits on Dec 14, 2022

• fix: parse close frame & move failWebsocketConnection

  KhafraDev

  committed
  71848d9

  Copy full SHA for 71848d9

• fix: read close reason and read entire close body

  KhafraDev

  committed
  b468029

  Copy full SHA for b468029

• fix: echo close frame if one hasn't been sent

  KhafraDev

  committed
  8839538

  Copy full SHA for 8839538

• fix: emit message event on message receive

  KhafraDev

  committed
  78b77a8

  Copy full SHA for 78b77a8

• fix: minor fixes

  KhafraDev

  committed
  6cfc42e

  Copy full SHA for 6cfc42e

• fix: ci

  KhafraDev

  committed
  7f1b5d4

  Copy full SHA for 7f1b5d4

• fix: set was clean exit after server receives close frame

  KhafraDev

  committed
  24ae13b

  Copy full SHA for 24ae13b

• fix: check if received close frame for clean close

  KhafraDev

  committed
  5086ce8

  Copy full SHA for 5086ce8

• fix: set sent close after writing frame

  KhafraDev

  committed
  6441dc3

  Copy full SHA for 6441dc3

Commits on Dec 15, 2022

• feat: implement error messages

  KhafraDev

  committed
  476a192

  Copy full SHA for 476a192

• fix: add error event handler to socket

  KhafraDev

  committed
  28c7ff6

  Copy full SHA for 28c7ff6

• fix: address reviews

  KhafraDev

  committed
  73128fd

  Copy full SHA for 73128fd