-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Korean Translation #282
Conversation
I also add hexdex link (#279) |
@nodeschool/seoul review please. 🙇 |
@@ -23,10 +26,11 @@ | |||
"index-upcoming-loading": "불러오는 중...", | |||
"index-upcoming-error": "죄송합니다. 이벤트를 불러올 수 없습니다", | |||
"index-upcoming-all-events": "모든 이벤트 보기", | |||
"index-upcoming-no-events": "다가올 이벤트가 없습니다 . 확인 하세요", | |||
"index-upcoming-no-events": "다가올 이벤트가 없습니다.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다가올 -> 다가오는?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about "개최될"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace '이벤트' with '일정'?
Also, how about '예정된'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for '예정된'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take 예정된.
2ee5a3c
to
7f74f98
Compare
@yous 이벤트 can not replace with 일정. It is not natural some context likes:
|
86cf53c
to
cd0ce93
Compare
@marocchino I got it. I'm fine with that. |
@yous Are you still review this? |
@marocchino I'm done. 😄 |
Thanks! |
No description provided.