Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New env var, dependency upd, cleanup #36

Merged
merged 8 commits into from
Aug 5, 2024
Merged

New env var, dependency upd, cleanup #36

merged 8 commits into from
Aug 5, 2024

Conversation

nohr-ai
Copy link
Owner

@nohr-ai nohr-ai commented Aug 5, 2024

Pre-season 2024

With a new season coming up it's about time to have a look at this wrapper.
Masterblaster have done some adjustments to their backend and with it moved the API from masterblaster to bedriftsligaen.

Updates

  • Base URL for Masterblaster is now expected as an env-variable instead of a hardcoded value. Affecting both end-users, dev and build.
  • Updating dependencies, and with it we're definitely not supporting Python below version 3.8.
  • Test organizations/teams should consist of 1 member instead of 2 from now on.
  • Legacy dependency group from the poetry configuration is removed.

@nohr-ai nohr-ai requested a review from mrtz-j August 5, 2024 06:36
@nohr-ai nohr-ai self-assigned this Aug 5, 2024
Copy link
Collaborator

@mrtz-j mrtz-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and runs on my machine™️


[tool.poetry.dev-dependencies]
aiohttp = "^3.10.1"
python-dateutil = "^2.9.0.post0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the intended version, right? 🤔

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently!
Haven't seen that naming before, but it is what pypi says 🤷

@mrtz-j mrtz-j mentioned this pull request Aug 5, 2024
@nohr-ai nohr-ai merged commit aa99f93 into beta Aug 5, 2024
4 checks passed
@nohr-ai nohr-ai deleted the o/base_url branch August 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants