fix: issue with bit check in from_be_bytes
#14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with the
from_be_bytes
preventing the use of the function when the number of bits of the bytes passed as argument is the same as the number of bits encoding the modulus.Problem*
In the original code, when
num_bits
yields the same value asmodulus_bits
the assert fails and the function is usuable.Summary*
As this behavior is not desired, simply replacing the strictly greater than with a greater than or equal fixes the issue:
Which is what this PR changes.
Additional Context
PR Checklist*
cargo fmt
on default settings.