Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming of audio devices under PipeWire #358

Merged
merged 1 commit into from
Nov 12, 2022

Commits on Nov 12, 2022

  1. Fix naming of audio devices under PipeWire

    Under PulseAudio, the user-friendly name for each audio device was
    stored under its `device.description` property. Under PipeWire,
    `device.description` is the name of the sound card, not the source/sink.
    This results in all source devices showing their sound card's name in
    NoiseTorch. Since I have multiple sources on the same sound card, it
    meant all my microphones had the same name, making NoiseTorch unusable.
    
    This commit changes the assignment of device names. When running under
    PipeWire, the `pulseaudio.Source.Description` field holds the correct
    device name, while the
    `pulseaudio.Source.PropList["device.description"]` field that was being
    used previously is the sound card's description.
    
    The NoiseTorch context must now be passed to the `getSources` and
    `getSinks` functions so they can check whether the program is running
    under PulseAudio or PipeWire.
    kdkasad committed Nov 12, 2022
    Configuration menu
    Copy the full SHA
    0f361e2 View commit details
    Browse the repository at this point in the history