Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Matlab compatibility #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improved Matlab compatibility #26

wants to merge 3 commits into from

Conversation

ShuhuaGao
Copy link

From the documentation of MATLAB on ellipke and ellipj, we see that the inputs to these functions can also be arrays. In the current implementation, we have to use the dot syntax to broadcast if we have an array of input values. However, this broadcasting syntax will lead to an array of tuples, which differs from that of MATLAB (tuple of arrays). Thus, I try to improve MATLAB compatibility by providing methods that accept array inputs directly.

Note that this PR does not comprise backward compatibility of this package, since I only add new methods. The implementation is rather simple and has been fully tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant