Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser interface #98

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Parser interface #98

merged 6 commits into from
Mar 11, 2024

Conversation

ladinesa
Copy link
Collaborator

Use parser class hierarchy with common parser method parse and abstract method write_to_archive.

@ladinesa ladinesa requested a review from JFRudzinski March 10, 2024 15:05
@ladinesa ladinesa self-assigned this Mar 10, 2024
Copy link
Collaborator

@JFRudzinski JFRudzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general question about parser maintenance: There are a number of these atomsitic parsers which only have a handful (or sometimes 0!) entries + I presume that the functionality of these parsers are not very good / up-to-date. We need to decide which parsers we continue to maintain and which we dump. I think the move to plugins is a reasonable time to make this decision.

Not sure what the best way to go about this other than recent usage. Anyway, not relevant for this MR, but we should discuss sometime.

@ladinesa
Copy link
Collaborator Author

Just a general question about parser maintenance: There are a number of these atomsitic parsers which only have a handful (or sometimes 0!) entries + I presume that the functionality of these parsers are not very good / up-to-date. We need to decide which parsers we continue to maintain and which we dump. I think the move to plugins is a reasonable time to make this decision.

Not sure what the best way to go about this other than recent usage. Anyway, not relevant for this MR, but we should discuss sometime.

yes, we can certainly do this.

@ladinesa
Copy link
Collaborator Author

@JFRudzinski are we ok with this pr?

@JFRudzinski
Copy link
Collaborator

@JFRudzinski are we ok with this pr?

Yes please go ahead

@ladinesa ladinesa merged commit 08cc88e into develop Mar 11, 2024
2 checks passed
@ladinesa ladinesa deleted the parser-interface branch March 11, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants