-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser interface #98
Parser interface #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a general question about parser maintenance: There are a number of these atomsitic parsers which only have a handful (or sometimes 0!) entries + I presume that the functionality of these parsers are not very good / up-to-date. We need to decide which parsers we continue to maintain and which we dump. I think the move to plugins is a reasonable time to make this decision.
Not sure what the best way to go about this other than recent usage. Anyway, not relevant for this MR, but we should discuss sometime.
yes, we can certainly do this. |
@JFRudzinski are we ok with this pr? |
Yes please go ahead |
Use parser class hierarchy with common parser method parse and abstract method write_to_archive.