Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): data race when tf fires multiple times & cond signal mistake #59

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

noneback
Copy link
Owner

…itfall

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.22%. Comparing base (a5028cf) to head (95cf09f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
node.go 73.91% 4 Missing and 2 partials ⚠️
graph.go 90.00% 1 Missing and 1 partial ⚠️
executor.go 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   91.75%   91.22%   -0.54%     
==========================================
  Files          12       12              
  Lines         643      661      +18     
==========================================
+ Hits          590      603      +13     
- Misses         38       40       +2     
- Partials       15       18       +3     
Flag Coverage Δ
unittests 91.22% <89.65%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noneback noneback changed the title fix(executor): data race when tf fires multiple times & cond single p… fix(executor): data race when tf fires multiple times & cond signal mistake Dec 26, 2024
@noneback noneback merged commit af29b1d into main Dec 26, 2024
1 of 3 checks passed
@noneback noneback deleted the dev_fix_data_race branch December 26, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant