CI: Rewrite build script for OBS 28 based on obs-text-pthread #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norihiro
force-pushed
the
obs-28-brew
branch
5 times, most recently
from
323291e to
8df5c78
Compare
norihiro
force-pushed
the
obs-28-brew
branch
2 times, most recently
from
b744cf0 to
501d831
Compare
This commit also starts to use zlib from obs-deps on Windows.
Also changes - Update libpng from 1.6.28 to 1.6.40 - Do not build examples This feature is not implemented in the released libvncserver but will be included in future release.
According to an issue packagesdev/packages#144, the file was intentionally replaced by the owner. Let's use the new one.
|
Tested on mac (arm64 and x86_64 on Rosetta). |
norihiro
force-pushed
the
obs-28-brew
branch
6 times, most recently
from
251b2ed to
40dec8a
Compare
|
Linking libraries on Windows looks ok according to $ strings obs-plugins/64bit/obs-vnc.dll | grep '\.dll$'
%s.dll
obs-vnc.dll
obs.dll
WSOCK32.dll
WS2_32.dll
w32-pthreads.dll
CRYPT32.dll
KERNEL32.dll
USER32.dll
ADVAPI32.dll
VCRUNTIME140.dll
api-ms-win-crt-string-l1-1-0.dll
api-ms-win-crt-stdio-l1-1-0.dll
api-ms-win-crt-heap-l1-1-0.dll
api-ms-win-crt-utility-l1-1-0.dll
api-ms-win-crt-time-l1-1-0.dll
api-ms-win-crt-runtime-l1-1-0.dll
api-ms-win-crt-convert-l1-1-0.dll
api-ms-win-crt-environment-l1-1-0.dll
api-ms-win-crt-filesystem-l1-1-0.dll
zlib.dll |
The openssl library is required by libvncclient. The dependencies should be controlled from libvncclient but it makes errors at link phase.
|
The DLL for Windows works ok now. The failure on macOS is caused by the updated agreement so that it's not related to this PR. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the same flow as norihiro/obs-text-pthread#43 to build macOS packages.
The build script for Windows is as same as #27 so that this PR will replace #27.
How Has This Been Tested?
General checklist