fix computation of melee and ranged coverage #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
approved these changes
Nov 17, 2023
|
I guess that's fine, sure. |
|
Does this fix #96...? |
|
Only part of it. It gets rid of those Melee and Ranged values, but it doesn't address the 150% coverage down in the materials section of the output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Armors which define multiple coverage values for different sublocations weren't falling back on the default coverage value for that location when no cover_melee and cover_ranged values were set. This could be seen in the tshirt, where it would display separate and bogus values for melee and ranged coverage even though no such coverages were defined in the JSON.