Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fp config from socket #4456

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fp config from socket #4456

wants to merge 16 commits into from

Conversation

zeffii
Copy link
Collaborator

@zeffii zeffii commented May 5, 2022

This makes it possible to configure a FilePath Node as a function of the kind of FilePath socket with which it is linked.

  • this introduces a new property (StringProperty) of the SvFilePathSocket called filepath_node_mode, the FilePath Node will look at this property use the mode therein to configure the SvFilePathFinder Operator.

SvFilePathFinder Operator can behave according to the kind of files it's used for.

i'm not sure this approach is sufficient. While this makes some functionality easier, it may interfere with flexibility in its current state. It may still be useful to add a features to draw_buttons function of the SvFilePathFinder Operator, which can let the user reset the mode - as a fail safe incase the automatic mode resulted in something undesirable.

@zeffii
Copy link
Collaborator Author

zeffii commented May 6, 2022

resolves #4446

if no-one has objections. this will evolve into something more useful as more filetypes are added

@zeffii
Copy link
Collaborator Author

zeffii commented May 11, 2022

not all nodes that use FilePath socket will make use of this feature, as most are currently self appending an extension, and only using the FilePath node to provide a location and file_name (without .ext). I'm reluctant to make changes to these nodes, even to the point where I might only commit the changes to the single FCStd write node. Or just close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant