Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT][FIX] jest + fixes #7 + custom value serializer #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

huafu
Copy link

@huafu huafu commented Jul 9, 2018

This PR does the following:


I wanted and tried to write tests for my fixes and feature using Vows, but I found it hard to understand and change (not to blame the way @notatestuser wrote tests but blaming Vows itself here). Also the vows version was not standard and I couldn't make the tests to pass originally.

So I decided to totally drop Vows in favor to Jest, a more well known and used test runner/lib. Tho I tried to re-wrote the tests as close as possible to the way original ones were written.

If this will make you (@notatestuser) drop my PR, I guess I'll keep "treeify": "github:huafu/treeify" in the package.json of the repo where I use your tool. But sorry, I can't spend more time trying to make original Vows tests to work :-/

@notatestuser
Copy link
Owner

I've spent a lot of time trying to update the vows test in this repo myself, thanks a lot for having more of a crack at it. I'll take a look and hopefully merge this for a major release!

@huafu
Copy link
Author

huafu commented Sep 12, 2018

@notatestuser any news on this?

@resynth1943
Copy link

@notatestuser still mastering the tests? 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: obj.hasOwnProperty is not a function at filterKeys
3 participants