[FEAT][FIX] jest + fixes #7 + custom value serializer #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
showValues
option ofasTree()
andasLines()
to be afunction
, in which case it'll be used to render values.I wanted and tried to write tests for my fixes and feature using Vows, but I found it hard to understand and change (not to blame the way @notatestuser wrote tests but blaming Vows itself here). Also the vows version was not standard and I couldn't make the tests to pass originally.
So I decided to totally drop Vows in favor to Jest, a more well known and used test runner/lib. Tho I tried to re-wrote the tests as close as possible to the way original ones were written.
If this will make you (@notatestuser) drop my PR, I guess I'll keep
"treeify": "github:huafu/treeify"
in thepackage.json
of the repo where I use your tool. But sorry, I can't spend more time trying to make original Vows tests to work :-/