Skip to content

Commit

Permalink
fix: lint
Browse files Browse the repository at this point in the history
  • Loading branch information
notdodo committed Nov 27, 2023
1 parent 2dd4490 commit 127ee48
Showing 1 changed file with 9 additions and 14 deletions.
23 changes: 9 additions & 14 deletions pkg/app/okta_neo4j.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,9 @@ type oktaNeo4jApp struct {
}

func (a *oktaNeo4jApp) Dump() {
users, _ := a.getUsers()
a.createNodes([]string{"User"}, flat(users))
groups, _ := a.getGroups()
a.createNodes([]string{"Group"}, flat(groups))
rules, _ := a.getRules()
a.createNodes([]string{"Rule"}, flat(rules))
a.createNodes([]string{"User"}, flat(a.getUsers()))

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
a.createNodes([]string{"Group"}, flat(a.getGroups()))

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.
a.createNodes([]string{"Rule"}, flat(a.getRules()))

Check warning

Code scanning / gosec

Errors unhandled. Warning

Errors unhandled.

// var groupIdsList [][]string

Expand All @@ -43,30 +40,28 @@ func (a *oktaNeo4jApp) Dump() {
// }
}

func (a *oktaNeo4jApp) getUsers() ([]*okta.User, error) {
func (a *oktaNeo4jApp) getUsers() []*okta.User {
users, err := a.oktaClient.GetUsers()
if err != nil {
a.logger.Error("Error fetching users from Okta:", "err", err)
}
return users, err
return users
}

func (a *oktaNeo4jApp) getGroups() ([]*okta.Group, error) {
func (a *oktaNeo4jApp) getGroups() []*okta.Group {
groups, err := a.oktaClient.GetGroups()
if err != nil {
a.logger.Error("Error fetching groups from Okta:", "err", err)
return nil, err
}
return groups, nil
return groups
}

func (a *oktaNeo4jApp) getRules() ([]*okta.GroupRule, error) {
func (a *oktaNeo4jApp) getRules() []*okta.GroupRule {
rules, err := a.oktaClient.GetGroupsRules()
if err != nil {
a.logger.Error("Error fetching rules from Okta:", "err", err)
return nil, err
}
return rules, err
return rules
}

func flat[T any](data []T) []map[string]interface{} {
Expand Down

0 comments on commit 127ee48

Please sign in to comment.