Merge pull request #1336 from novasamatech/fix/zoom-transition-memory…

…-leak fix memory leak
novasamatech · Jan 15, 2025 · c6b0819 · c6b0819
2 parents b6d65ce + 8a7d18a
commit c6b0819
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/novawallet/Modules/DApp/DAppBrowser/DAppBrowserInteractor.swift b/novawallet/Modules/DApp/DAppBrowser/DAppBrowserInteractor.swift
@@ -407,7 +407,7 @@ extension DAppBrowserInteractor: DAppBrowserInteractorInputProtocol {
         securedLayer.scheduleExecutionIfAuthorized { [weak self] in
             self?.logger?.debug("Did receive \(name) message from \(host): \(message)")
 
-            self?.verifyPhishing(for: host) { [weak self] isNotPhishing in
+            self?.verifyPhishing(for: host) { isNotPhishing in
                 if isNotPhishing {
                     let queueMessage = QueueMessage(
                         host: host,

diff --git a/novawallet/Modules/DApp/DAppBrowser/DAppBrowserTabTransition.swift b/novawallet/Modules/DApp/DAppBrowser/DAppBrowserTabTransition.swift
@@ -11,7 +11,7 @@ enum DAppBrowserTabTransition {
             guard let tabId else { return }
 
             let options = UIViewController.Transition.ZoomOptions()
-            options.interactiveDismissShouldBegin = { context in
+            options.interactiveDismissShouldBegin = { [weak destController] context in
                 guard let destinationController = destController as? DAppBrowserViewController else {
                     return true
                 }

diff --git a/novawallet/Modules/DApp/DAppBrowser/DAppBrowserViewController.swift b/novawallet/Modules/DApp/DAppBrowser/DAppBrowserViewController.swift
@@ -327,8 +327,8 @@ private extension DAppBrowserViewController {
 
         navigationController?.setNavigationBarHidden(false, animated: true)
 
-        slidingAnimator.animate(block: {
-            self.rootView.setIsToolbarHidden(false)
+        slidingAnimator.animate(block: { [weak self] in
+            self?.rootView.setIsToolbarHidden(false)
         }, completionBlock: nil)
     }
 
@@ -341,8 +341,8 @@ private extension DAppBrowserViewController {
 
         navigationController?.setNavigationBarHidden(true, animated: true)
 
-        slidingAnimator.animate(block: {
-            self.rootView.setIsToolbarHidden(true)
+        slidingAnimator.animate(block: { [weak self] in
+            self?.rootView.setIsToolbarHidden(true)
         }, completionBlock: nil)
     }
 

diff --git a/novawallet/Modules/DApp/DAppBrowser/Tabs/DAppBrowserTabManager/DAppBrowserTabManager.swift b/novawallet/Modules/DApp/DAppBrowser/Tabs/DAppBrowserTabManager/DAppBrowserTabManager.swift
@@ -391,7 +391,7 @@ extension DAppBrowserTabManager: DAppBrowserTabManagerProtocol {
     }
 
     func removeAll(for metaIds: Set<MetaAccountModel.Id>?) {
-        let wrapper = removeAllWrapper(for: metaIds)
+        let wrapper = removeAllWrapper(metaIds)
 
         execute(
             wrapper: wrapper,