Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push notifications bugfixes #1003

Merged
merged 6 commits into from
Mar 14, 2024
Merged

Push notifications bugfixes #1003

merged 6 commits into from
Mar 14, 2024

Conversation

lynx56
Copy link
Contributor

@lynx56 lynx56 commented Mar 13, 2024 •
edited
Loading

Fixed Bugs:

  • Show disabled state after not allowing on welcome screen (#8693ygf1h)
  • Crash on add delegation (#86941tu1b)
  • Filter networks for notifications based on chains.json (#86941vmw7)
  • Blank push notification settings screen (#86941y5hk)
  • Update disabled state as to layouts (#8693ygf1n)
  • Disable notifications if all notification types are off (#86940awnr)
  • Save becomes Active when go to settings menu and get back (#86940akjb)

Bonus:

  • Enable all chain settings if chain was selected in governance
  • Show push settings screen after setup

@lynx56 lynx56 requested a review from ERussel March 13, 2024 07:57
@stepanLav
Copy link
Member

Task linked: CU-8693ygf1h iOS. Show disabled state after not allowing on welcome screen

@stepanLav
Copy link
Member

Task linked: CU-86940akjb iOS. Save becomes Active when go to settings menu and get back

@stepanLav
Copy link
Member

Task linked: CU-8693ygf1n iOS. Update disabled state as to layouts

@stepanLav
Copy link
Member

Task linked: CU-86941tu1b iOS. Crash on add delegation

@stepanLav
Copy link
Member

Task linked: CU-86940awnr iOS. Disable notifications if all notification types are off

@stepanLav
Copy link
Member

Task linked: CU-86941vmw7 iOS. Filter networks for notifications based on chains.json

@stepanLav
Copy link
Member

Task linked: CU-86941y5hk iOS. Blank push notification settings screen

@lynx56 lynx56 merged commit a833cdb into base/push-notifications Mar 14, 2024
3 checks passed
@lynx56 lynx56 deleted the fix/push-notifications-bugfixes branch March 14, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ERussel ERussel ERussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lynx56 @stepanLav @ERussel