Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dapps fixes #1319

Merged
merged 26 commits into from
Jan 7, 2025
Merged

Fix/dapps fixes #1319

merged 26 commits into from
Jan 7, 2025

Conversation

svojsu
Copy link
Contributor

@svojsu svojsu commented Dec 27, 2024 •
edited
Loading

  • Refactor custom card modal presentation
  • Introduce ModalCardPresentation
  • Process corners accordingly to current device screen
  • Close favorites on removing last dapp
  • Show available dapp when searching by url
  • Don't show malicious dapp alert when searching by available dapp url
  • Fix settings screen layout
  • Fix hiding toolbars after orientation changes
  • Clean view hierarchy on browser widget close
  • Show and hide categories with animation
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-27.at.14.42.50.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-27.at.14.40.41.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-27.at.14.39.32.mp4

@svojsu
ModalCard Presentation Factory implemented
78729c5
@svojsu
Merge branch 'feature/custom-modal-presentation' into fix/card-modal-…
82c7044 
…presentation
@svojsu
bugfixes
a8942f9 
- close favorites on removing last dapp
- Show available dapp when searching by url
- Don't show malicious dapp alert when searching by available dapp url
- Fix settings screen layout
@svojsu
fix hiding bars after orientation changes
e26233a
@svojsu
clean view hierarchy on widget close
892a76d
@svojsu
show and hide categories
f70cf4d
@svojsu svojsu requested a review from ERussel December 27, 2024 12:35
svojsu added 14 commits December 27, 2024 15:10
@svojsu
progress
dbf46a1
@svojsu
fix close browser widget
a743b02
@svojsu
introduce new card modal transition with ModalCardPresentationFactory
00470d1
@svojsu
update modals layout on browser widget close
dba4f22
@svojsu
remove delegates references
64c5882
@svojsu
fix important flow navigation presented in card
6f99f7e
@svojsu
various fixes
f34702f 
- Handle corners mutation for every device model
- fix browser widget background
- update corners on different stages of transition
@svojsu
editable table case processing
c6468d7
@svojsu
Merge branch 'fix/card-modal-presentation' into fix/dapps-fixes
b1d4d45 
# Conflicts:
#	novawallet/Modules/DApp/DAppBrowser/DAppBrowserWidget/Transition/Common/DAppBrowserCloseTransition.swift
@svojsu
Merge branch 'develop' into fix/dapps-fixes
d636f01 
# Conflicts:
#	novawallet.xcodeproj/project.pbxproj
@svojsu
merge fixes
08e6436
@svojsu
Merge branch 'feature/custom-modal-presentation' into fix/dapps-fixes
cd08ca3
@svojsu
fix header button for dapp list collection
cf67f05
@svojsu
fix cells moving in modal card presentation
954b0a2
@svojsu svojsu requested a review from ERussel January 6, 2025 11:26
@svojsu svojsu merged commit e2a5356 into feature/custom-modal-presentation Jan 7, 2025
1 check failed
@svojsu svojsu deleted the fix/dapps-fixes branch January 7, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ERussel ERussel ERussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svojsu @ERussel