New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tabs for wallet #1327

Merged

svojsu merged 2 commits into base/seamless-dapp-browser from feature/tabs-for-wallet

Jan 9, 2025

Contributor

svojsu commented Jan 8, 2025 •

edited

Loading

Purpose

Opened browser tabs (i.e., dApps) are meant to be associated with the wallet that was selected at the time. This PR adds:

metaId property to the CDDAppBrowserTab entity
Changes to the logic in DAppBrowserTabManager for handling tab persistence and state
Use StreamableProvider to subscribe to selected wallet changes instead of using EventCenter

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-01-08.at.18.30.36.mov

svojsu added 2 commits

January 7, 2025 21:20


          bind DAppBrowserTab entity with metaId

ddb2d38


          operate on tabs based on selected wallet

98cdaf3

svojsu requested a review from ERussel

January 8, 2025 16:53

svojsu marked this pull request as ready for review

January 8, 2025 16:58

ERussel approved these changes

View reviewed changes

svojsu merged commit cd2803c into base/seamless-dapp-browser

1 check failed

svojsu deleted the feature/tabs-for-wallet branch

January 9, 2025 12:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet