Fix/dapps fixes #1330
Merged
Fix/dapps fixes #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERussel
approved these changes
Jan 14, 2025
| let title: String | ||
| let subtitle: String | ||
|
|
||
| let imageViewModel: StaticImageViewModel |
There was a problem hiding this comment.
Shouldn't it be ImageViewModelProtocol?
| ) | ||
| else { return nil } | ||
|
|
||
| let domain = urlString[range] |
There was a problem hiding this comment.
Looks complicated. What is wrong with pageURL.host?
There was a problem hiding this comment.
pageURL.host might return nil for complex domains that contains subdomains i.e. app.parallel.finance
| @@ -162,12 +193,12 @@ extension NovaMainAppContainerViewController { | |||
| rootView.addSubview(bottomView) | |||
|
|
|||
| let topContainerBottomOffset = Constants.topContainerBottomOffset(for: view) | |||
| let minimizedWidgetHeight = Constants.minimizedWidgetHeight(for: view) | |||
| let widgetTopConstraintInset = UIScreen.main.bounds.height | |||
There was a problem hiding this comment.
Can we use bottom of the container itself instead of height of the screen? Feel not comfortable with assumptions about screen height
There was a problem hiding this comment.
Yeah, I just came up with better approach. Gonna update soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There are few thing needed to be fixed and added for preparing Seamless DApp feature. Most of them are just layout and sorting/filtering fixes.
DAppListmodule.DAppSearchby query input.DAppSearch.NovaMainAppContainerlayout so it no longer breaks during screen rotations with device orientation changes.DAppIconViewModelFactoryto handle DApp icon and favicon logic.SOLUTION SCREENSHOTS