Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak #1336

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix memory leak #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion novawallet/Modules/DApp/DAppBrowser/DAppBrowserInteractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ extension DAppBrowserInteractor: DAppBrowserInteractorInputProtocol {
securedLayer.scheduleExecutionIfAuthorized { [weak self] in
self?.logger?.debug("Did receive \(name) message from \(host): \(message)")

self?.verifyPhishing(for: host) { [weak self] isNotPhishing in
self?.verifyPhishing(for: host) { isNotPhishing in
if isNotPhishing {
let queueMessage = QueueMessage(
host: host,
Expand Down
2 changes: 1 addition & 1 deletion novawallet/Modules/DApp/DAppBrowser/DAppBrowserTabTransition.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ enum DAppBrowserTabTransition {
guard let tabId else { return }

let options = UIViewController.Transition.ZoomOptions()
options.interactiveDismissShouldBegin = { context in
options.interactiveDismissShouldBegin = { [weak destController] context in
guard let destinationController = destController as? DAppBrowserViewController else {
return true
}
Expand Down
8 changes: 4 additions & 4 deletions novawallet/Modules/DApp/DAppBrowser/DAppBrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,8 @@ private extension DAppBrowserViewController {

navigationController?.setNavigationBarHidden(false, animated: true)

slidingAnimator.animate(block: {
self.rootView.setIsToolbarHidden(false)
slidingAnimator.animate(block: { [weak self] in
self?.rootView.setIsToolbarHidden(false)
}, completionBlock: nil)
}

Expand All @@ -341,8 +341,8 @@ private extension DAppBrowserViewController {

navigationController?.setNavigationBarHidden(true, animated: true)

slidingAnimator.animate(block: {
self.rootView.setIsToolbarHidden(true)
slidingAnimator.animate(block: { [weak self] in
self?.rootView.setIsToolbarHidden(true)
}, completionBlock: nil)
}

Expand Down
2 changes: 1 addition & 1 deletion novawallet/Modules/DApp/DAppBrowser/Tabs/DAppBrowserTabManager/DAppBrowserTabManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ extension DAppBrowserTabManager: DAppBrowserTabManagerProtocol {
}

func removeAll(for metaIds: Set<MetaAccountModel.Id>?) {
let wrapper = removeAllWrapper(for: metaIds)
let wrapper = removeAllWrapper(metaIds)

execute(
wrapper: wrapper,
Expand Down