Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings #1337

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix warnings #1337

merged 2 commits into from
Jan 16, 2025

Conversation

svojsu
Copy link
Contributor

@svojsu svojsu commented Jan 16, 2025

Fixed warnings around DAppBrowser, ModalCardPresentation and few factories

@svojsu svojsu requested a review from ERussel January 16, 2025 08:03
ERussel
ERussel approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@ERussel ERussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check, please, also minimizedWidgetHeight in the NovaMainAppContainerViewController

@svojsu svojsu merged commit ce2580d into develop Jan 16, 2025
1 check passed
@svojsu svojsu deleted the fix/fix-warnings branch January 16, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ERussel ERussel ERussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svojsu @ERussel