Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Password intersection with borders when importing keyset via banana split #2430

Open
wants to merge 3 commits into
base: fix/xcode16-build
Choose a base branch
from

Conversation

ERussel
Copy link
Contributor

@ERussel ERussel commented Feb 5, 2025

Purpose

When a user imports keyset via banansplit and enters the password from it the text field can intersect the eye button

Scope

  • added a separate modifier for plain textfield
  • refactored SecureTextField to use horizontal stack instead of ZStack to layout text field and eye button

TODOs

Discussion

Screenshots

Screenshot 2025-02-05 at 10 00 39

@ERussel ERussel requested a review from krodak as a code owner February 5, 2025 09:17
@ERussel ERussel requested a review from sergkononenko February 6, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants