-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save new expected client size on resize #1801
Conversation
Windows test failed because of windows machine itself, please rerun if needed |
Thanks for your contribution, good to see that you included a unit test. Could you please describe the issue you saw before applying your fix? |
Resize back and forth between full screen and regular seems to work fine for me. What am I looking for? |
Hi, I've rechecked functionality with What I've noticed: there are two resize handlers which are executed separately: |
The two functions have very different uses. The fact that |
I am using same VNC server (qemu's VNC with websocket) for all tests. Than, it is kinda weird that Is it correct to assume that my test case correctly emulates expected real world RFB behavior for resizing? |
I'm not sure what you mean. I don't know the details of your test case. You said you were working on a reproducible sample, do you have something like that? |
Sorry I got busy and wasn't able to create clean example. But I've tried latest noVnc and it has the issue fixed, so we can close it |
Hello,
_handleResize()
doesn't save new expected size if window was resized which cause a bug if window was resized to different size, and then return back to original (e.g. go fullscreen and back to windowed).Since the expected client size wasn't changed during fullscreen resize, the
_handleResize
would not resize window during resize to original size as it would exit because ofthis._clientHasExpectedSize()
.The PR add save of new expected client size to fix the issue