chore(framework): Fix ESLint issues

novuhq · Jan 9, 2025 · 97d3c44 · 97d3c44
1 parent f8fac8f
commit 97d3c44
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 5 deletions.
diff --git a/.source b/.source
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -262,6 +262,7 @@ export default tsEslint.config(
       'unused-imports': fixupPluginRules(unusedImports),
     },
     rules: {
+      'id-length': 'off',
       'max-len': 'off',
       '@typescript-eslint/no-explicit-any': 'error',
       'import/prefer-default-export': 0,

diff --git a/packages/framework/src/client.ts b/packages/framework/src/client.ts
@@ -49,7 +49,6 @@ import { validateData } from './validators';
 import { mockSchema } from './jsonSchemaFaker';
 import { prettyPrintDiscovery } from './resources/workflow/pretty-print-discovery';
 import { deepMerge } from './utils/object.utils';
-import build from 'next/dist/build';
 
 function isRuntimeInDevelopment() {
   return ['development', undefined].includes(process.env.NODE_ENV);

diff --git a/packages/framework/src/handler.ts b/packages/framework/src/handler.ts
@@ -275,6 +275,7 @@ export class NovuRequestHandler<Input extends any[] = any[], Output = any> {
          * Log bridge server errors to assist the Developer in debugging errors with their integration.
          * This path is reached when the Bridge application throws an error, ensuring they can see the error in their logs.
          */
+        // eslint-disable-next-line @typescript-eslint/no-base-to-string
         log((l) => l.error(error.message || error.toString()));
       }
 
@@ -283,6 +284,7 @@ export class NovuRequestHandler<Input extends any[] = any[], Output = any> {
       return this.createError(error);
     } else {
       const bridgeError = new BridgeError(error);
+      // eslint-disable-next-line @typescript-eslint/no-base-to-string
       log((l) => l.error(bridgeError.message || bridgeError.toString()));
 
       return this.createError(bridgeError);

diff --git a/packages/framework/src/servers/h3.ts b/packages/framework/src/servers/h3.ts
@@ -59,6 +59,7 @@ export const serve = (options: ServeHandlerOptions) => {
             String(event.path),
             `${process.env.NODE_ENV === 'development' ? 'http' : 'https'}://${String(getHeader(event, 'host'))}`
           ),
+        // eslint-disable-next-line @typescript-eslint/no-base-to-string
         queryString: (key) => String(getQuery(event)[key]),
         transformResponse: (actionRes) => {
           const { res } = event.node;

diff --git a/packages/framework/src/servers/nuxt.ts b/packages/framework/src/servers/nuxt.ts
@@ -27,6 +27,7 @@ export const serve = (options: ServeHandlerOptions) => {
      * TODO: Fix this
      */
     handler: (event: H3Event) => ({
+      // eslint-disable-next-line @typescript-eslint/no-base-to-string
       queryString: (key) => String(getQuery(event)[key]),
       body: () => readBody(event),
       headers: (key) => getHeader(event, key),

diff --git a/packages/framework/src/utils/log.utils.ts b/packages/framework/src/utils/log.utils.ts
@@ -62,11 +62,17 @@ export function log(message: string | ((formatter: typeof f) => string)): void {
   }
 
   if (typeof message === 'string') {
+    // eslint-disable-next-line no-console
     console.log(message);
   } else if (typeof message === 'function') {
+    // eslint-disable-next-line no-console
     console.log(message(f));
   }
 }
 
-log.enable = () => (enabled = true);
-log.disable = () => (enabled = false);
+log.enable = () => {
+  enabled = true;
+};
+log.disable = () => {
+  enabled = false;
+};
diff --git a/packages/framework/src/utils/options.utils.ts b/packages/framework/src/utils/options.utils.ts
@@ -15,5 +15,5 @@ export function resolveLogging(providedLogging?: boolean): boolean {
   }
 
   // Disable verbose logging in test and production environments
-  return ['test', 'production'].includes(process.env.NODE_ENV);
+  return !['test', 'production'].includes(process.env.NODE_ENV);
 }