SuspiciousMessageMode: Don't report 0 #199
Merged
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented a check for mode: 0 in the `SuspiciousMessageMode.ts` to trigger warnings on redundant mode settings. - Updated test cases in `SuspiciousMessageMode.tact` to ensure mode: 0 is flagged as unnecessary. - Adjusted expected output in `SuspiciousMessageMode.expected` to reflect the new checks.
jubnzv
reviewed
Oct 25, 2024
|
Let's just ignore these at the moment, we don't need a warning. |
jubnzv
reviewed
Oct 28, 2024
|
We will also need the changelog entry for these changes. |
jubnzv
reviewed
Nov 2, 2024
jubnzv
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #197
CHANGELOG.mdyarn test-all